From patchwork Thu Jan 4 19:38:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ladislav Michl X-Patchwork-Id: 10145585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BB38E6034B for ; Thu, 4 Jan 2018 19:38:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A87C526256 for ; Thu, 4 Jan 2018 19:38:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9AA7A28844; Thu, 4 Jan 2018 19:38:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DD0026256 for ; Thu, 4 Jan 2018 19:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752964AbeADTif (ORCPT ); Thu, 4 Jan 2018 14:38:35 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:53456 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbeADTif (ORCPT ); Thu, 4 Jan 2018 14:38:35 -0500 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990435AbeADTieI9rWx (ORCPT ); Thu, 4 Jan 2018 20:38:34 +0100 Date: Thu, 4 Jan 2018 20:38:33 +0100 From: Ladislav Michl To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, Bernie Thompson Subject: [PATCH v2 3/5] video: udlfb: Remove noisy warnings Message-ID: <20180104193833.GD22612@lenoch> References: <20180104193623.GA22612@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180104193623.GA22612@lenoch> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These warnings comes from times of driver development and do not carry any usefull debugging information. Signed-off-by: Ladislav Michl --- Changes: - v2: New patch drivers/video/fbdev/udlfb.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index d4e15d97a264..4a6644432970 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -921,11 +921,7 @@ static void dlfb_free(struct kref *kref) struct dlfb_data *dev = container_of(kref, struct dlfb_data, kref); vfree(dev->backing_buffer); - kfree(dev->edid); - - pr_warn("freeing dlfb_data %p\n", dev); - kfree(dev); } @@ -942,8 +938,6 @@ static void dlfb_free_framebuffer(struct dlfb_data *dev) struct fb_info *info = dev->info; if (info) { - int node = info->node; - unregister_framebuffer(info); if (info->cmap.len != 0) @@ -958,8 +952,6 @@ static void dlfb_free_framebuffer(struct dlfb_data *dev) /* Assume info structure is freed after this point */ framebuffer_release(info); - - pr_warn("fb_info for /dev/fb%d has been freed\n", node); } /* ref taken in probe() as part of registering framebfufer */ @@ -1060,8 +1052,6 @@ static int dlfb_ops_set_par(struct fb_info *info) u16 *pix_framebuffer; int i; - pr_notice("set_par mode %dx%d\n", info->var.xres, info->var.yres); - result = dlfb_set_video_mode(dev, &info->var); if ((result == 0) && (dev->fb_count == 0)) { @@ -1164,8 +1154,6 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info) unsigned char *new_fb; unsigned char *new_back = NULL; - pr_warn("Reallocating framebuffer. Addresses will change!\n"); - new_len = info->fix.line_length * info->var.yres; if (PAGE_ALIGN(new_len) > old_len) { @@ -1415,9 +1403,6 @@ static ssize_t edid_show( if (off + count > dev->edid_size) count = dev->edid_size - off; - pr_info("sysfs edid copy %p to %p, %d bytes\n", - dev->edid, buf, (int) count); - memcpy(buf, dev->edid, count); return count; @@ -1443,7 +1428,6 @@ static ssize_t edid_store( if (!dev->edid || memcmp(src, dev->edid, src_size)) return -EINVAL; - pr_info("sysfs written EDID is new default\n"); dlfb_ops_set_par(fb_info); return src_size; } @@ -1827,8 +1811,6 @@ static void dlfb_free_urb_list(struct dlfb_data *dev) int ret; unsigned long flags; - pr_notice("Freeing all render urbs\n"); - /* keep waiting and freeing, until we've got 'em all */ while (count--) { @@ -1907,8 +1889,6 @@ static int dlfb_alloc_urb_list(struct dlfb_data *dev, int count, size_t size) dev->urbs.count = i; dev->urbs.available = i; - pr_notice("allocated %d %d byte urbs\n", i, (int) size); - return i; }