| Message ID | 20181013151707.32210-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent | expand |
On Sat, Oct 13, 2018 at 5:17 PM Christoph Hellwig <hch@lst.de> wrote: > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/cpufreq/tegra186-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c > index 1f59966573aa..f1e09022b819 100644 > --- a/drivers/cpufreq/tegra186-cpufreq.c > +++ b/drivers/cpufreq/tegra186-cpufreq.c > @@ -121,7 +121,7 @@ static struct cpufreq_frequency_table *init_vhint_table( > void *virt; > > virt = dma_alloc_coherent(bpmp->dev, sizeof(*data), &phys, > - GFP_KERNEL | GFP_DMA32); > + GFP_KERNEL); > if (!virt) > return ERR_PTR(-ENOMEM); > > -- > 2.19.1 >
On Mon, Oct 15, 2018 at 09:43:04AM +0200, Rafael J. Wysocki wrote: > On Sat, Oct 13, 2018 at 5:17 PM Christoph Hellwig <hch@lst.de> wrote: > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Can you pick it up through the cpufreq tree?
On Wed, Oct 17, 2018 at 9:19 AM Christoph Hellwig <hch@lst.de> wrote: > > On Mon, Oct 15, 2018 at 09:43:04AM +0200, Rafael J. Wysocki wrote: > > On Sat, Oct 13, 2018 at 5:17 PM Christoph Hellwig <hch@lst.de> wrote: > > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Can you pick it up through the cpufreq tree? Sure, I'll do that, thanks!
diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c index 1f59966573aa..f1e09022b819 100644 --- a/drivers/cpufreq/tegra186-cpufreq.c +++ b/drivers/cpufreq/tegra186-cpufreq.c @@ -121,7 +121,7 @@ static struct cpufreq_frequency_table *init_vhint_table( void *virt; virt = dma_alloc_coherent(bpmp->dev, sizeof(*data), &phys, - GFP_KERNEL | GFP_DMA32); + GFP_KERNEL); if (!virt) return ERR_PTR(-ENOMEM);
The DMA API does its own zone decisions based on the coherent_dma_mask. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/cpufreq/tegra186-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)