From patchwork Tue Feb 26 11:19:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 10829921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 96E72180E for ; Tue, 26 Feb 2019 11:28:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 841E32AA6F for ; Tue, 26 Feb 2019 11:28:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 738222B3F4; Tue, 26 Feb 2019 11:28:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 103FC2B332 for ; Tue, 26 Feb 2019 11:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726004AbfBZL2O (ORCPT ); Tue, 26 Feb 2019 06:28:14 -0500 Received: from smtp02.tmcz.cz ([93.153.104.113]:52974 "EHLO smtp02.tmcz.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbfBZL2O (ORCPT ); Tue, 26 Feb 2019 06:28:14 -0500 X-Greylist: delayed 395 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Feb 2019 06:28:11 EST Received: from smtp02.tmcz.cz (localhost [127.0.0.1]) by sagator.hkvnode045 (Postfix) with ESMTP id AFF9694BB0B; Tue, 26 Feb 2019 12:21:32 +0100 (CET) X-Sagator-Scanner: 1.3.1-1 at hkvnode046; log(status(custom_action(quarantine(clamd()))), status(custom_action(quarantine(SpamAssassinD())))) X-Sagator-ID: 20190226-122132-0001-02206-eEZtDh@hkvnode046 Received: from leontynka.twibright.com (unknown [109.183.129.149]) by smtp02.tmcz.cz (Postfix) with ESMTPS; Tue, 26 Feb 2019 12:21:32 +0100 (CET) Received: from root by leontynka.twibright.com with local (Exim 4.89) (envelope-from ) id 1gyana-0002pZ-4a; Tue, 26 Feb 2019 12:21:22 +0100 Message-Id: <20190226112121.910471265@twibright.com> User-Agent: quilt/0.63-1 Date: Tue, 26 Feb 2019 12:19:45 +0100 From: Mikulas Patocka To: Mikulas Patocka , Bernie Thompson , Bartlomiej Zolnierkiewicz , Ladislav Michl Cc: linux-fbdev@vger.kernel.org Subject: [PATCH 1/3] udlfb: delete the unused parameter for dlfb_handle_damage References: <20190226111944.505404435@twibright.com> MIME-Version: 1.0 Content-Disposition: inline; filename=dlfb-remove-unused-variables.patch Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the unused parameter "data" and unused variable "ret". Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- drivers/video/fbdev/udlfb.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) Index: linux-4.19.25/drivers/video/fbdev/udlfb.c =================================================================== --- linux-4.19.25.orig/drivers/video/fbdev/udlfb.c 2019-02-25 15:42:57.000000000 +0100 +++ linux-4.19.25/drivers/video/fbdev/udlfb.c 2019-02-25 15:43:16.000000000 +0100 @@ -594,10 +594,9 @@ static int dlfb_render_hline(struct dlfb return 0; } -static int dlfb_handle_damage(struct dlfb_data *dlfb, int x, int y, - int width, int height, char *data) +static int dlfb_handle_damage(struct dlfb_data *dlfb, int x, int y, int width, int height) { - int i, ret; + int i; char *cmd; cycles_t start_cycles, end_cycles; int bytes_sent = 0; @@ -641,7 +640,7 @@ static int dlfb_handle_damage(struct dlf *cmd++ = 0xAF; /* Send partial buffer remaining before exiting */ len = cmd - (char *) urb->transfer_buffer; - ret = dlfb_submit_urb(dlfb, urb, len); + dlfb_submit_urb(dlfb, urb, len); bytes_sent += len; } else dlfb_urb_completion(urb); @@ -679,7 +678,7 @@ static ssize_t dlfb_ops_write(struct fb_ (u32)info->var.yres); dlfb_handle_damage(dlfb, 0, start, info->var.xres, - lines, info->screen_base); + lines); } return result; @@ -695,7 +694,7 @@ static void dlfb_ops_copyarea(struct fb_ sys_copyarea(info, area); dlfb_handle_damage(dlfb, area->dx, area->dy, - area->width, area->height, info->screen_base); + area->width, area->height); } static void dlfb_ops_imageblit(struct fb_info *info, @@ -706,7 +705,7 @@ static void dlfb_ops_imageblit(struct fb sys_imageblit(info, image); dlfb_handle_damage(dlfb, image->dx, image->dy, - image->width, image->height, info->screen_base); + image->width, image->height); } static void dlfb_ops_fillrect(struct fb_info *info, @@ -717,7 +716,7 @@ static void dlfb_ops_fillrect(struct fb_ sys_fillrect(info, rect); dlfb_handle_damage(dlfb, rect->dx, rect->dy, rect->width, - rect->height, info->screen_base); + rect->height); } /* @@ -859,8 +858,7 @@ static int dlfb_ops_ioctl(struct fb_info if (area.y > info->var.yres) area.y = info->var.yres; - dlfb_handle_damage(dlfb, area.x, area.y, area.w, area.h, - info->screen_base); + dlfb_handle_damage(dlfb, area.x, area.y, area.w, area.h); } return 0; @@ -1065,8 +1063,7 @@ static int dlfb_ops_set_par(struct fb_in pix_framebuffer[i] = 0x37e6; } - dlfb_handle_damage(dlfb, 0, 0, info->var.xres, info->var.yres, - info->screen_base); + dlfb_handle_damage(dlfb, 0, 0, info->var.xres, info->var.yres); return 0; }