| Message ID | 20190322051759.15007-8-tomli@tomli.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | implement 2D acceleration, minor cleanups, doc updates. | expand |
On Fri, Mar 22, 2019 at 01:17:59PM +0800, Yifeng Li wrote: > I have working on the sm712fb driver for a while and have some familiarity > with this hardware, I'll be helping working on and testing problems of this > driver, so add myself to the MAINTAINERS file. Technically I donot have any problem with this, you seem to know more about SM712 than I know. But Teddy Wang is also an existing maintainer and I think there should be an ack from him before this is accepted. > > Signed-off-by: Yifeng Li <tomli@tomli.me> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index dce5c099f43c..3f6686f0f020 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13871,6 +13871,7 @@ F: drivers/input/touchscreen/silead.c > F: drivers/platform/x86/touchscreen_dmi.c > > SILICON MOTION SM712 FRAME BUFFER DRIVER > +M: Tom Li <tomli@tomli.me> Sorry, I am confused. Is your name "Tom Li"? Then why is your Signed-off-by: and From: name different? -- Regards Sudip
On Sun, Mar 31, 2019 at 08:08:01PM +0100, Sudip Mukherjee wrote: > Technically I donot have any problem with this, you seem to know more > about SM712 than I know. But Teddy Wang is also an existing maintainer > and I think there should be an ack from him before this is accepted. Okay, I'll write a personal mail to Teddy. I think it could be a separate patch to allow more time for communication, but the problem is that, if the MAINTAINERS and the new changes are not merged at the same time, users who have problems may unable to see my name and E-mail address for reporting problems. I think I can send PATCH v3 early for your review, meanwhile I can write a personal E-mail to Teddy. > On Fri, Mar 22, 2019 at 01:17:59PM +0800, Yifeng Li wrote: > > SILICON MOTION SM712 FRAME BUFFER DRIVER > > +M: Tom Li <tomli@tomli.me> > > Sorry, I am confused. Is your name "Tom Li"? Then why is your > Signed-off-by: and From: name different? Sorry for the confusion. "Tom Li" is my common name. I use this name both in offline and online activities, and I've used it to contribute various patches to free and open source projects and mailing list discussions as well. But the "Signed-off-by" name is the legal name. Linux Kernel's "Developer's Certificate of Origin" requires the use of legal name in sign-offs. I think I should write my name as `Yifeng "Tom" Li` in MAINTAINERS to avoid the confusion. Thanks for your code review, I've noted your suggestions and I'll send PATCH v3 soon. Thanks, Tom Li
On Mon, Apr 1, 2019 at 6:41 PM Tom Li <tomli@tomli.me> wrote: > > On Sun, Mar 31, 2019 at 08:08:01PM +0100, Sudip Mukherjee wrote: > > Technically I donot have any problem with this, you seem to know more > > about SM712 than I know. But Teddy Wang is also an existing maintainer > > and I think there should be an ack from him before this is accepted. > > Okay, I'll write a personal mail to Teddy. I think it could be a separate > patch to allow more time for communication, but the problem is that, if > the MAINTAINERS and the new changes are not merged at the same time, users > who have problems may unable to see my name and E-mail address for reporting > problems. git will not forget that you have done the changes. :) So anyone who has a problem only needs to do a "git blame" to see who has done it and the user will get your name and email to contact you. If that is the only reason you think your name is added as a maintainer then I guess that is not a valid concern and then in that case I am not seeing any need to add your name in maintainer. Bartlomiej can you advise please.
On 04/02/2019 11:09 PM, Sudip Mukherjee wrote: > On Mon, Apr 1, 2019 at 6:41 PM Tom Li <tomli@tomli.me> wrote: >> >> On Sun, Mar 31, 2019 at 08:08:01PM +0100, Sudip Mukherjee wrote: >>> Technically I donot have any problem with this, you seem to know more >>> about SM712 than I know. But Teddy Wang is also an existing maintainer >>> and I think there should be an ack from him before this is accepted. >> >> Okay, I'll write a personal mail to Teddy. I think it could be a separate >> patch to allow more time for communication, but the problem is that, if The first version of the patchset was posted on 2nd February and Teddy was on Cc:. Unless there is an explicit NACK (with valid rationale) from him lets assume that he is fine with having another co-maintainer. >> the MAINTAINERS and the new changes are not merged at the same time, users >> who have problems may unable to see my name and E-mail address for reporting >> problems. > > git will not forget that you have done the changes. :) > So anyone who has a problem only needs to do a "git blame" to see who > has done it and the user will get your name and email to contact you. > If that is the only reason you think your name is added as a The original patch description suggests that there is more than that: "I have working on the sm712fb driver for a while and have some familiarity with this hardware, I'll be helping working on and testing problems of this driver, so add myself to the MAINTAINERS file." > maintainer then I guess that is not a valid concern and then in that > case I am not seeing any need to add your name in maintainer. > > Bartlomiej can you advise please. 2D acceleration seems to be an important contribution to the driver (functionality wise and code wise -> it grows the driver source code by ~25%) and it shows that Yifeng knows the driver well. He has also access to SM720 (you have SM712 only) to verify potential issues with the future driver changes (I assume that he don't mind getting Cc:ed on all driver related patches, not that there should be much of them). Thus I think that it would be beneficial to add him as the driver co-maintainer but I would prefer to keep the current ordering in the MAINTAINERS file, IOW something like this: Index: b/MAINTAINERS =================================================================== --- a/MAINTAINERS 2019-04-01 13:12:10.607271933 +0200 +++ b/MAINTAINERS 2019-04-03 15:39:54.404646279 +0200 @@ -14143,6 +14143,7 @@ SILICON MOTION SM712 FRAME BUFFER DRIVER M: Sudip Mukherjee <sudipm.mukherjee@gmail.com> M: Teddy Wang <teddy.wang@siliconmotion.com> M: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> +M: Yifeng Li <tomli@tomli.me> L: linux-fbdev@vger.kernel.org S: Maintained F: drivers/video/fbdev/sm712* Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Wed, Apr 3, 2019 at 2:53 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > > On 04/02/2019 11:09 PM, Sudip Mukherjee wrote: > > On Mon, Apr 1, 2019 at 6:41 PM Tom Li <tomli@tomli.me> wrote: > >> > >> On Sun, Mar 31, 2019 at 08:08:01PM +0100, Sudip Mukherjee wrote: > >>> Technically I donot have any problem with this, you seem to know more > >>> about SM712 than I know. But Teddy Wang is also an existing maintainer > >>> and I think there should be an ack from him before this is accepted. > >> > >> Okay, I'll write a personal mail to Teddy. I think it could be a separate > >> patch to allow more time for communication, but the problem is that, if > > The first version of the patchset was posted on 2nd February and > Teddy was on Cc:. Unless there is an explicit NACK (with valid > rationale) from him lets assume that he is fine with having another > co-maintainer. > > >> the MAINTAINERS and the new changes are not merged at the same time, users > >> who have problems may unable to see my name and E-mail address for reporting > >> problems. > > > > git will not forget that you have done the changes. :) > > So anyone who has a problem only needs to do a "git blame" to see who > > has done it and the user will get your name and email to contact you. > > If that is the only reason you think your name is added as a > > The original patch description suggests that there is more than > that: > > "I have working on the sm712fb driver for a while and have some > familiarity with this hardware, I'll be helping working on and > testing problems of this driver, so add myself to the MAINTAINERS > file." > > > maintainer then I guess that is not a valid concern and then in that > > case I am not seeing any need to add your name in maintainer. > > > > Bartlomiej can you advise please. > > 2D acceleration seems to be an important contribution to the driver > (functionality wise and code wise -> it grows the driver source code > by ~25%) and it shows that Yifeng knows the driver well. > > He has also access to SM720 (you have SM712 only) to verify potential > issues with the future driver changes (I assume that he don't mind > getting Cc:ed on all driver related patches, not that there should be > much of them). Agreed with all the points.
diff --git a/MAINTAINERS b/MAINTAINERS index dce5c099f43c..3f6686f0f020 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13871,6 +13871,7 @@ F: drivers/input/touchscreen/silead.c F: drivers/platform/x86/touchscreen_dmi.c SILICON MOTION SM712 FRAME BUFFER DRIVER +M: Tom Li <tomli@tomli.me> M: Sudip Mukherjee <sudipm.mukherjee@gmail.com> M: Teddy Wang <teddy.wang@siliconmotion.com> M: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
I have working on the sm712fb driver for a while and have some familiarity with this hardware, I'll be helping working on and testing problems of this driver, so add myself to the MAINTAINERS file. Signed-off-by: Yifeng Li <tomli@tomli.me> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)