From patchwork Tue Jun 18 07:41:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marko Kohtala X-Patchwork-Id: 11001063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48C1914B6 for ; Tue, 18 Jun 2019 07:41:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AE24288EE for ; Tue, 18 Jun 2019 07:41:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F5D928A08; Tue, 18 Jun 2019 07:41:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB593288EE for ; Tue, 18 Jun 2019 07:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfFRHlz (ORCPT ); Tue, 18 Jun 2019 03:41:55 -0400 Received: from mail-wr1-f99.google.com ([209.85.221.99]:45944 "EHLO mail-wr1-f99.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbfFRHly (ORCPT ); Tue, 18 Jun 2019 03:41:54 -0400 Received: by mail-wr1-f99.google.com with SMTP id f9so12693366wre.12 for ; Tue, 18 Jun 2019 00:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=okoko.fi; s=okoko; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=77CACbLG8YOOXSUPh2HvtcwJqatz/ApGlIF/fbxQ6MM=; b=K4G1zQPJ6Avx1u05WN/I0mLZ1eldWEYzvqTshfQHtPvsMJpxkvHeOewu0QPh7/0vof fPUBYzsij0DMRALgWrkiW3fKmEX02BJDb8RMk2qMaScMXglntIKmv5+FfD9A79HrYk1g C6cKvPAC7l/9KumffEhWIiBTkYZKhPDz1pWwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=77CACbLG8YOOXSUPh2HvtcwJqatz/ApGlIF/fbxQ6MM=; b=tjwePz5OJUZYjAXAimuiyq+L3H5aRzcWcY6loTgcDDpTZ749A9eNZA7FdOWuiHUBzE i7Y0dq4ss7RfLca6prpUs7E2IAd6ogsfa90T7jIcd3Pv1z+8J4U6wfBKTB6lmT5mlb3T S3AQ5U6AWRQi3TEglX1IJSl6i/pW4TWIyaIRxPEwUD/wGh5iru1na7NzsH1vg1v1vKkF A7SmH9iEsPQoM7uapwvIrHP8xZ5wFRMfXKSAuMnQ49MkV5H+y3O88yQ1l8zl+si7ttao GN0yFtR+fJ6DGjH/cKmCkOZvo4QAbOYmW1zWl4HuAA1BzbQxBW+gFCC4+ltJ/BqWoSAX Gs2g== X-Gm-Message-State: APjAAAU62FIXUrTadmKBmLBmOvh6JgvkAXePPtUw00gTEyxJOo70KltQ JVeqjynmrN3T2vqhGuEJYN3sd7zU2tQBKnGzX6G2/N5UeQOgFQ== X-Google-Smtp-Source: APXvYqyGE/GgF3llWsrqocTXT6oGvv/+cbVnAi4GTQVeTr/DTh0qherzKRGe3g2B64lGDtKlirYWQdQUNe/k X-Received: by 2002:adf:c506:: with SMTP id q6mr65175136wrf.219.1560843713168; Tue, 18 Jun 2019 00:41:53 -0700 (PDT) Received: from localhost.localdomain (46-163-209-30.blcnet.fi. [46.163.209.30]) by smtp-relay.gmail.com with ESMTPS id l18sm212063wrn.66.2019.06.18.00.41.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 00:41:53 -0700 (PDT) X-Relaying-Domain: okoko.fi From: Marko Kohtala To: linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Bartlomiej Zolnierkiewicz , Mark Rutland , Rob Herring , Daniel Vetter , David Airlie , =?utf-8?b?TWljaGFsIFZva8OhxI0=?= , Marko Kohtala Subject: [PATCH 3/6] video: ssd1307fb: Start page range at page_offset Date: Tue, 18 Jun 2019 10:41:08 +0300 Message-Id: <20190618074111.9309-4-marko.kohtala@okoko.fi> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190618074111.9309-1-marko.kohtala@okoko.fi> References: <20190618074111.9309-1-marko.kohtala@okoko.fi> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The page_offset was only applied to the end of the page range. This caused the display updates to cause a scrolling effect on the display because the amount of data written to the display did not match the range display expected. Fixes: 301bc0675b67 ("video: ssd1307fb: Make use of horizontal addressing mode") Signed-off-by: Marko Kohtala --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 9ab00e0dadc7..86f2b79f3ed5 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -433,7 +433,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, 0x0); + ret = ssd1307fb_write_cmd(par->client, par->page_offset); if (ret < 0) return ret;