| Message ID | 20190722182439.44844-2-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | video: of: display_timing: Adjust err printing of of_get_display_timing() | expand |
Hi Douglas, Thank you for the patch. On Mon, Jul 22, 2019 at 11:24:36AM -0700, Douglas Anderson wrote: > From code inspection it can be seen that of_get_display_timing() is > lacking an of_node_put(). Add it. > > Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > drivers/video/of_display_timing.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c > index f5c1c469c0af..5eedae0799f0 100644 > --- a/drivers/video/of_display_timing.c > +++ b/drivers/video/of_display_timing.c > @@ -119,6 +119,7 @@ int of_get_display_timing(const struct device_node *np, const char *name, > struct display_timing *dt) > { > struct device_node *timing_np; > + int ret; > > if (!np) > return -EINVAL; > @@ -129,7 +130,11 @@ int of_get_display_timing(const struct device_node *np, const char *name, > return -ENOENT; > } > > - return of_parse_display_timing(timing_np, dt); > + ret = of_parse_display_timing(timing_np, dt); > + > + of_node_put(timing_np); > + > + return ret; > } > EXPORT_SYMBOL_GPL(of_get_display_timing); >
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index f5c1c469c0af..5eedae0799f0 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -119,6 +119,7 @@ int of_get_display_timing(const struct device_node *np, const char *name, struct display_timing *dt) { struct device_node *timing_np; + int ret; if (!np) return -EINVAL; @@ -129,7 +130,11 @@ int of_get_display_timing(const struct device_node *np, const char *name, return -ENOENT; } - return of_parse_display_timing(timing_np, dt); + ret = of_parse_display_timing(timing_np, dt); + + of_node_put(timing_np); + + return ret; } EXPORT_SYMBOL_GPL(of_get_display_timing);
From code inspection it can be seen that of_get_display_timing() is lacking an of_node_put(). Add it. Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/video/of_display_timing.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)