| Message ID | 20190827110854.12574-4-peda@axentia.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add possibility to specify the number of displayed logos | expand |
Hi Peter, On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin <peda@axentia.se> wrote: > The variable is only ever used from fbcon.c which is linked into the > same module. Therefore, the export is not needed. > > Signed-off-by: Peter Rosin <peda@axentia.se> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> But note that the same is true for fb_class, so perhaps it can be added (or better, removed ;-)? Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[] and num_registered_fb, those can go, too. Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo() itself? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 2019-08-27 13:35, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin <peda@axentia.se> wrote: >> The variable is only ever used from fbcon.c which is linked into the >> same module. Therefore, the export is not needed. >> >> Signed-off-by: Peter Rosin <peda@axentia.se> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > But note that the same is true for fb_class, so perhaps it can be added > (or better, removed ;-)? Right. Someone please let me know if 3/3 needs to be extended. I'm also happy to just drop it... > Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[] > and num_registered_fb, those can go, too. > > Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo() > itself? Maybe there should be a small drivers/video/fbdev/core/fbmem.h file (or something) with these "internal" declarations, to hide some clutter currently in include/linux/fb.h? Feels like that could be done later, after these other cleanups you mention, so that the new file has a few more things to declare. Cheers, Peter
On 8/29/19 9:08 AM, Peter Rosin wrote: > On 2019-08-27 13:35, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin <peda@axentia.se> wrote: >>> The variable is only ever used from fbcon.c which is linked into the >>> same module. Therefore, the export is not needed. >>> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >> >> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Thanks, patch queued for v5.6 (also sorry for the delay). >> But note that the same is true for fb_class, so perhaps it can be added >> (or better, removed ;-)? > > Right. Someone please let me know if 3/3 needs to be extended. I'm also > happy to just drop it... Please send incremental patch for fb_class. >> Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[] >> and num_registered_fb, those can go, too. >> >> Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo() >> itself? > > Maybe there should be a small drivers/video/fbdev/core/fbmem.h file (or > something) with these "internal" declarations, to hide some clutter currently > in include/linux/fb.h? Sounds like a good idea. > Feels like that could be done later, after these other cleanups you mention, > so that the new file has a few more things to declare. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index c7ddcb72025b..d45e59ac351b 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -54,7 +54,6 @@ int num_registered_fb __read_mostly; EXPORT_SYMBOL(num_registered_fb); bool fb_center_logo __read_mostly; -EXPORT_SYMBOL(fb_center_logo); int fb_logo_count __read_mostly = -1;
The variable is only ever used from fbcon.c which is linked into the same module. Therefore, the export is not needed. Signed-off-by: Peter Rosin <peda@axentia.se> --- drivers/video/fbdev/core/fbmem.c | 1 - 1 file changed, 1 deletion(-)