| Message ID | 20201021121512.17774-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | video/fbdev/core: Mark debug-only variable as __maybe_unused | expand |
Hi Thomas. On Wed, Oct 21, 2020 at 02:15:12PM +0200, Thomas Zimmermann wrote: > Compiling fbcon.c gives > > ../drivers/video/fbdev/core/fbcon.c: In function 'fbcon_exit': > ../drivers/video/fbdev/core/fbcon.c:3358:7: warning: variable 'pending' set but not used [-Wunused-but-set-variable] > 3358 | int pending = 0; > | ^~~~~~~ > > The variable pending is only used for fbcon debugging. It's unused > otherwise. Mark it accordingly. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> A better fix would be to replace the few uses of DPRINTK() with pr_dbg(). pr_info() is alread in use. ofc, the next step would be to replace all prink() with their pr_ counterparts. Peilin, maybe this is one for your nice cleanups in fbcon? Sam
Hi Sam, On Sun, Nov 01, 2020 at 10:47:18AM +0100, Sam Ravnborg wrote: > Hi Thomas. > > On Wed, Oct 21, 2020 at 02:15:12PM +0200, Thomas Zimmermann wrote: > > Compiling fbcon.c gives > > > > ../drivers/video/fbdev/core/fbcon.c: In function 'fbcon_exit': > > ../drivers/video/fbdev/core/fbcon.c:3358:7: warning: variable 'pending' set but not used [-Wunused-but-set-variable] > > 3358 | int pending = 0; > > | ^~~~~~~ > > > > The variable pending is only used for fbcon debugging. It's unused > > otherwise. Mark it accordingly. > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > A better fix would be to replace the few uses of DPRINTK() with > pr_dbg(). pr_info() is alread in use. > > ofc, the next step would be to replace all prink() with their pr_ > counterparts. > > Peilin, maybe this is one for your nice cleanups in fbcon? Sure, I will send a patch replacing all printk() except DPRINTK(). Thank you for the suggestion! Peilin
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index d03f62369734..aca1512b6e86 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3355,7 +3355,7 @@ static void fbcon_exit(void) #endif for_each_registered_fb(i) { - int pending = 0; + int __maybe_unused pending = 0; mapped = 0; info = registered_fb[i];
Compiling fbcon.c gives ../drivers/video/fbdev/core/fbcon.c: In function 'fbcon_exit': ../drivers/video/fbdev/core/fbcon.c:3358:7: warning: variable 'pending' set but not used [-Wunused-but-set-variable] 3358 | int pending = 0; | ^~~~~~~ The variable pending is only used for fbcon debugging. It's unused otherwise. Mark it accordingly. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)