| Message ID | 20220204134347.1187749-4-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | drm/tiny: Add driver for Solomon SSD1307 OLED displays | expand |
On Fri, Feb 04, 2022 at 02:43:46PM +0100, Javier Martinez Canillas wrote: > To make sure that tools like the get_maintainer.pl script will suggest > to Cc me if patches are posted for this driver. > > Also include the Device Tree binding for the old ssd1307fb fbdev driver > since the new DRM driver was made compatible with the existing binding. ... > drivers/gpu/drm/drm_format_helper.c | 2 +- Nothing about this in the commit message... Stray change?
Hello Andy, On 2/4/22 14:57, Andy Shevchenko wrote: > On Fri, Feb 04, 2022 at 02:43:46PM +0100, Javier Martinez Canillas wrote: >> To make sure that tools like the get_maintainer.pl script will suggest >> to Cc me if patches are posted for this driver. >> >> Also include the Device Tree binding for the old ssd1307fb fbdev driver >> since the new DRM driver was made compatible with the existing binding. > > ... > >> drivers/gpu/drm/drm_format_helper.c | 2 +- > > Nothing about this in the commit message... > > Stray change? > Sigh, I'm not sure how added that change. Just ignore it, I'll fix it on v3 or when applying if there isn't another revision of this series. Best regards,
On Fri, Feb 04, 2022 at 03:12:17PM +0100, Javier Martinez Canillas wrote: > On 2/4/22 14:57, Andy Shevchenko wrote: > > On Fri, Feb 04, 2022 at 02:43:46PM +0100, Javier Martinez Canillas wrote: ... > > Stray change? > > Sigh, I'm not sure how added that change. Just ignore it, I'll fix it > on v3 or when applying if there isn't another revision of this series. I believe v3 is warranted due to the other patch review.
On 2/4/22 15:28, Andy Shevchenko wrote: > On Fri, Feb 04, 2022 at 03:12:17PM +0100, Javier Martinez Canillas wrote: >> On 2/4/22 14:57, Andy Shevchenko wrote: >>> On Fri, Feb 04, 2022 at 02:43:46PM +0100, Javier Martinez Canillas wrote: > > ... > >>> Stray change? >> >> Sigh, I'm not sure how added that change. Just ignore it, I'll fix it >> on v3 or when applying if there isn't another revision of this series. > > I believe v3 is warranted due to the other patch review. > Agreed. Thanks a lot for your feedback and comments. Best regards,
diff --git a/MAINTAINERS b/MAINTAINERS index d03ad8da1f36..9061488a4113 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6102,6 +6102,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/repaper.txt F: drivers/gpu/drm/tiny/repaper.c +DRM DRIVER FOR SOLOMON SSD130X OLED DISPLAYS +M: Javier Martinez Canillas <javierm@redhat.com> +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +F: drivers/gpu/drm/tiny/ssd130x.c + DRM DRIVER FOR QEMU'S CIRRUS DEVICE M: Dave Airlie <airlied@redhat.com> M: Gerd Hoffmann <kraxel@redhat.com> diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm/drm_format_helper.c index cdce4b7c25d9..c3c1372fb771 100644 --- a/drivers/gpu/drm/drm_format_helper.c +++ b/drivers/gpu/drm/drm_format_helper.c @@ -661,6 +661,6 @@ void drm_fb_xrgb8888_to_mono_reversed(void *dst, unsigned int dst_pitch, const v dst_pitch = drm_rect_width(clip); drm_fb_xrgb8888_to_gray8(dst, dst_pitch, src, fb, clip); - drm_fb_gray8_to_mono_reversed(dst, dst_pitch, dst, fb, clip); + drm_fb_gray8_to_mono_reversed(dst, dst_pitch, dst, clip); } EXPORT_SYMBOL(drm_fb_xrgb8888_to_mono_reversed);