| Message ID | 20220521195942.645048-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | xen: remove setting of 'transp' parameter | expand |
On Sun, May 22, 2022 at 3:22 AM Tom Rix <trix@redhat.com> wrote: > cppcheck reports > [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function. > > The value parameter 'transp' is not used, so setting it can be removed. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 21.05.22 21:59, Tom Rix wrote: > cppcheck reports > [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function. > > The value parameter 'transp' is not used, so setting it can be removed. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 5/21/22 21:59, Tom Rix wrote: > cppcheck reports > [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function. > > The value parameter 'transp' is not used, so setting it can be removed. > > Signed-off-by: Tom Rix <trix@redhat.com> applied to the fbdev tree. Thanks! Helge > --- > drivers/video/fbdev/xen-fbfront.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > index 3bed357a9870..4d2694d904aa 100644 > --- a/drivers/video/fbdev/xen-fbfront.c > +++ b/drivers/video/fbdev/xen-fbfront.c > @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, > red = CNVT_TOHW(red, info->var.red.length); > green = CNVT_TOHW(green, info->var.green.length); > blue = CNVT_TOHW(blue, info->var.blue.length); > - transp = CNVT_TOHW(transp, info->var.transp.length); > #undef CNVT_TOHW > > v = (red << info->var.red.offset) |
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 3bed357a9870..4d2694d904aa 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, red = CNVT_TOHW(red, info->var.red.length); green = CNVT_TOHW(green, info->var.green.length); blue = CNVT_TOHW(blue, info->var.blue.length); - transp = CNVT_TOHW(transp, info->var.transp.length); #undef CNVT_TOHW v = (red << info->var.red.offset) |
cppcheck reports [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function. The value parameter 'transp' is not used, so setting it can be removed. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/video/fbdev/xen-fbfront.c | 1 - 1 file changed, 1 deletion(-)