| Message ID | 20221101150947.67377-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/2] fbdev: ssd1307fb: Drop optional dependency | expand |
On 11/1/22 16:09, Andy Shevchenko wrote: > Only a single out of three devices need a PWM, so from driver it's > optional. Moreover it's a single driver in the entire kernel that > currently selects PWM. Unfortunately this selection is a root cause > of the circular dependencies when we want to enable optional PWM > for some other drivers that select GPIOLIB. > > Fixes: a2ed00da5047 ("drivers/video: add support for the Solomon SSD1307 OLED Controller") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Both patches applied to fbdev git tree. Thanks! Helge > --- > drivers/video/fbdev/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index a98987aa2784..b88d8bfe992e 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2218,7 +2218,6 @@ config FB_SSD1307 > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > select FB_DEFERRED_IO > - select PWM > select FB_BACKLIGHT > help > This driver implements support for the Solomon SSD1307
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index a98987aa2784..b88d8bfe992e 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2218,7 +2218,6 @@ config FB_SSD1307 select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT select FB_DEFERRED_IO - select PWM select FB_BACKLIGHT help This driver implements support for the Solomon SSD1307
Only a single out of three devices need a PWM, so from driver it's optional. Moreover it's a single driver in the entire kernel that currently selects PWM. Unfortunately this selection is a root cause of the circular dependencies when we want to enable optional PWM for some other drivers that select GPIOLIB. Fixes: a2ed00da5047 ("drivers/video: add support for the Solomon SSD1307 OLED Controller") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/video/fbdev/Kconfig | 1 - 1 file changed, 1 deletion(-)