| Message ID | 20230510085239.1253896-1-mweigand2017@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] backlight: lm3630a: turn off both led strings when display is blank | expand |
On Wed, May 10, 2023 at 10:52:39AM +0200, Maximilian Weigand wrote: > From: Maximilian Weigand <mweigand@mweigand.net> > > Use backlight_is_blank() to determine if the led strings should be turned > off in the update_status() functions of both strings. > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > Signed-off-by: Maximilian Weigand <mweigand@mweigand.net> Looks good. Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
On Wed, 10 May 2023, Maximilian Weigand wrote: > From: Maximilian Weigand <mweigand@mweigand.net> > > Use backlight_is_blank() to determine if the led strings should be turned > off in the update_status() functions of both strings. > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> I moved this tag to the correct place and ... > Signed-off-by: Maximilian Weigand <mweigand@mweigand.net> > --- > Changes in v2: > - fix description, replace display_is_black() with backlight_is_black() > - use backlight_get_brightness() instead of accessing the property > directly > > drivers/video/backlight/lm3630a_bl.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Applied, thanks
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index d8c42acecb5d..faf92c8d70c1 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -202,7 +202,9 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl) usleep_range(1000, 2000); /* minimum brightness is 0x04 */ ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness); - if (bl->props.brightness < 0x4) + + if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4)) + /* turn the string off */ ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0); else ret |= lm3630a_update(pchip, REG_CTRL, @@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl) usleep_range(1000, 2000); /* minimum brightness is 0x04 */ ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness); - if (bl->props.brightness < 0x4) + + if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4)) + /* turn the string off */ ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0); else ret |= lm3630a_update(pchip, REG_CTRL,