| Message ID | 20230728145824.616687-3-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | pwm: Drop useless member "pwm" from struct pwm_device | expand |
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > struct pwm_device::pwm is a write-only variable in the pwm core and used > nowhere apart from this and another dev_dbg. So it isn't useful to > identify the used PWM. Emit the PWM's label instead in the debug > message. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 7/28/23 16:58, Uwe Kleine-König wrote: > struct pwm_device::pwm is a write-only variable in the pwm core and used > nowhere apart from this and another dev_dbg. So it isn't useful to > identify the used PWM. Emit the PWM's label instead in the debug > message. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> applied. Thanks! Helge > --- > drivers/video/fbdev/ssd1307fb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 11c373798279..46881a691549 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) > /* Enable the PWM */ > pwm_enable(par->pwm); > > - dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n", > - par->pwm->pwm, pwm_get_period(par->pwm)); > + dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n", > + par->pwm->label, pwm_get_period(par->pwm)); > } > > /* Set initial contrast */
On Fri, Jul 28, 2023 at 04:58:23PM +0200, Uwe Kleine-König wrote: > struct pwm_device::pwm is a write-only variable in the pwm core and used > nowhere apart from this and another dev_dbg. So it isn't useful to > identify the used PWM. Emit the PWM's label instead in the debug > message. Do we have firmware node of PWM available? I would print it rather than some (possibly non-unique) string.
Javier Martinez Canillas <javierm@redhat.com> writes: > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > >> struct pwm_device::pwm is a write-only variable in the pwm core and used >> nowhere apart from this and another dev_dbg. So it isn't useful to >> identify the used PWM. Emit the PWM's label instead in the debug >> message. >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> --- > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Pushed to drm-misc (drm-misc-next). Thanks!
Hello, On Sat, Sep 09, 2023 at 04:38:28PM +0200, Javier Martinez Canillas wrote: > Javier Martinez Canillas <javierm@redhat.com> writes: > > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > > >> struct pwm_device::pwm is a write-only variable in the pwm core and used > >> nowhere apart from this and another dev_dbg. So it isn't useful to > >> identify the used PWM. Emit the PWM's label instead in the debug > >> message. > >> > >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > >> --- > > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > > > > Pushed to drm-misc (drm-misc-next). Thanks! JFTR: This patch is already in linus/master. And Javier pushed "drm/ssd130x: Print the PWM's label instead of its number" to drm-misc-next which is great. So the "Pushed to ..." mail is just in reply to the wrong patch in this thread and in git everything is fine. Thanks Uwe
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: Hello Uwe, > Hello, > > On Sat, Sep 09, 2023 at 04:38:28PM +0200, Javier Martinez Canillas wrote: >> Javier Martinez Canillas <javierm@redhat.com> writes: >> >> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: >> > >> >> struct pwm_device::pwm is a write-only variable in the pwm core and used >> >> nowhere apart from this and another dev_dbg. So it isn't useful to >> >> identify the used PWM. Emit the PWM's label instead in the debug >> >> message. >> >> >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> >> --- >> > >> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >> > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > > JFTR: This patch is already in linus/master. And Javier pushed > "drm/ssd130x: Print the PWM's label instead of its number" to > drm-misc-next which is great. So the "Pushed to ..." mail is just in > reply to the wrong patch in this thread and in git everything is fine. > Ups, that's correct. Thanks a lot for pointing that out! > Thanks > Uwe >
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 11c373798279..46881a691549 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) /* Enable the PWM */ pwm_enable(par->pwm); - dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n", - par->pwm->pwm, pwm_get_period(par->pwm)); + dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n", + par->pwm->label, pwm_get_period(par->pwm)); } /* Set initial contrast */
struct pwm_device::pwm is a write-only variable in the pwm core and used nowhere apart from this and another dev_dbg. So it isn't useful to identify the used PWM. Emit the PWM's label instead in the debug message. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)