diff mbox series

staging: sm750fb: fix sii164InitChip function name

Message ID 20230815043759.404423-1-alkuor@gmail.com (mailing list archive)
State Superseded
Headers show
Series staging: sm750fb: fix sii164InitChip function name | expand

Commit Message

Abdel Alkuor Aug. 15, 2023, 4:37 a.m. UTC 
Adhere to Linux Kernel coding style. Found by checkpatch.

Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
---
 drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
 drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
 drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Nam Cao Aug. 15, 2023, 5:35 a.m. UTC | #1 
On Tue, Aug 15, 2023 at 12:37:59AM -0400, Abdel Alkuor wrote:
> Adhere to Linux Kernel coding style. Found by checkpatch.
> 
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
>  drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index e0c7ff3352bf..8b81e8642f9e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -14,7 +14,7 @@
>  static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
>  #ifdef DVI_CTRL_SII164
>  	{
> -		.init = sii164InitChip,
> +		.init = sii164_init_chip,
>  		.get_vendor_id = sii164_get_vendor_id,
>  		.get_device_id = sii164GetDeviceID,
>  #ifdef SII164_FULL_FUNCTIONS
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 3da1796cd7aa..d162e1a16584 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -72,7 +72,7 @@ unsigned short sii164GetDeviceID(void)
>   */
>  
>  /*
> - *  sii164InitChip
> + *  sii164_init_chip
>   *      This function initialize and detect the DVI controller chip.
>   *
>   *  Input:
> @@ -118,7 +118,7 @@ unsigned short sii164GetDeviceID(void)
>   *      0   - Success
>   *     -1   - Fail.
>   */
> -long sii164InitChip(unsigned char edge_select,
> +long sii164_init_chip(unsigned char edge_select,
>  		    unsigned char bus_select,
>  		    unsigned char dual_edge_clk_select,
>  		    unsigned char hsync_enable,

I think you introduce new checkpatch warnings here.

> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
> index ca330f6a43e2..13420bcc282c 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.h
> +++ b/drivers/staging/sm750fb/ddk750_sii164.h
> @@ -16,7 +16,7 @@ enum sii164_hot_plug_mode {
>  };
>  
>  /* Silicon Image SiI164 chip prototype */
> -long sii164InitChip(unsigned char edgeSelect,
> +long sii164_init_chip(unsigned char edgeSelect,
>  		    unsigned char busSelect,
>  		    unsigned char dualEdgeClkSelect,
>  		    unsigned char hsyncEnable,

Also here.

Best regards,
Nam
>
Abdel Alkuor Aug. 15, 2023, 6:44 p.m. UTC | #2 
On Tue, Aug 15, 2023 at 07:35:59AM +0200, Nam Cao wrote:
> On Tue, Aug 15, 2023 at 12:37:59AM -0400, Abdel Alkuor wrote:
> > Adhere to Linux Kernel coding style. Found by checkpatch.
> > 
> > Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
> >  drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
> >  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> > index e0c7ff3352bf..8b81e8642f9e 100644
> > --- a/drivers/staging/sm750fb/ddk750_dvi.c
> > +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> > @@ -14,7 +14,7 @@
> >  static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> >  #ifdef DVI_CTRL_SII164
> >  	{
> > -		.init = sii164InitChip,
> > +		.init = sii164_init_chip,
> >  		.get_vendor_id = sii164_get_vendor_id,
> >  		.get_device_id = sii164GetDeviceID,
> >  #ifdef SII164_FULL_FUNCTIONS
> > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> > index 3da1796cd7aa..d162e1a16584 100644
> > --- a/drivers/staging/sm750fb/ddk750_sii164.c
> > +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> > @@ -72,7 +72,7 @@ unsigned short sii164GetDeviceID(void)
> >   */
> >  
> >  /*
> > - *  sii164InitChip
> > + *  sii164_init_chip
> >   *      This function initialize and detect the DVI controller chip.
> >   *
> >   *  Input:
> > @@ -118,7 +118,7 @@ unsigned short sii164GetDeviceID(void)
> >   *      0   - Success
> >   *     -1   - Fail.
> >   */
> > -long sii164InitChip(unsigned char edge_select,
> > +long sii164_init_chip(unsigned char edge_select,
> >  		    unsigned char bus_select,
> >  		    unsigned char dual_edge_clk_select,
> >  		    unsigned char hsync_enable,
> 
> I think you introduce new checkpatch warnings here.
> 
> > diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
> > index ca330f6a43e2..13420bcc282c 100644
> > --- a/drivers/staging/sm750fb/ddk750_sii164.h
> > +++ b/drivers/staging/sm750fb/ddk750_sii164.h
> > @@ -16,7 +16,7 @@ enum sii164_hot_plug_mode {
> >  };
> >  
> >  /* Silicon Image SiI164 chip prototype */
> > -long sii164InitChip(unsigned char edgeSelect,
> > +long sii164_init_chip(unsigned char edgeSelect,
> >  		    unsigned char busSelect,
> >  		    unsigned char dualEdgeClkSelect,
> >  		    unsigned char hsyncEnable,
> 
> Also here.
> 
> Best regards,
> Nam
> > 

Hi Nam,

Thanks for the review. I will update the indentation in V2.

Abdel
diff mbox series

Patch

diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index e0c7ff3352bf..8b81e8642f9e 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -14,7 +14,7 @@ 
 static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
 #ifdef DVI_CTRL_SII164
 	{
-		.init = sii164InitChip,
+		.init = sii164_init_chip,
 		.get_vendor_id = sii164_get_vendor_id,
 		.get_device_id = sii164GetDeviceID,
 #ifdef SII164_FULL_FUNCTIONS
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 3da1796cd7aa..d162e1a16584 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -72,7 +72,7 @@  unsigned short sii164GetDeviceID(void)
  */
 
 /*
- *  sii164InitChip
+ *  sii164_init_chip
  *      This function initialize and detect the DVI controller chip.
  *
  *  Input:
@@ -118,7 +118,7 @@  unsigned short sii164GetDeviceID(void)
  *      0   - Success
  *     -1   - Fail.
  */
-long sii164InitChip(unsigned char edge_select,
+long sii164_init_chip(unsigned char edge_select,
 		    unsigned char bus_select,
 		    unsigned char dual_edge_clk_select,
 		    unsigned char hsync_enable,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index ca330f6a43e2..13420bcc282c 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -16,7 +16,7 @@  enum sii164_hot_plug_mode {
 };
 
 /* Silicon Image SiI164 chip prototype */
-long sii164InitChip(unsigned char edgeSelect,
+long sii164_init_chip(unsigned char edgeSelect,
 		    unsigned char busSelect,
 		    unsigned char dualEdgeClkSelect,
 		    unsigned char hsyncEnable,