| Message ID | 20240717090102.968152-4-jfalempe@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE | expand |
Jocelyn Falempe <jfalempe@redhat.com> writes: > Now that fbcon has the skip_panic option, there is no more conflicts > between drm_panic and fbcon. > Remove the build time dependency, so they can be both enabled. > > Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com> > --- > drivers/gpu/drm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 6dd0016fc9cd..a22cab218004 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -107,7 +107,7 @@ config DRM_KMS_HELPER > > config DRM_PANIC > bool "Display a user-friendly message when a kernel panic occurs" > - depends on DRM && !(FRAMEBUFFER_CONSOLE && VT_CONSOLE) > + depends on DRM This is great. Thanks for finding an alternative approach! I don't see any issues this time, because there is no locking involved. But let's see what others think about it. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Wed, Jul 17, 2024 at 12:09:46PM +0200, Javier Martinez Canillas wrote: > Jocelyn Falempe <jfalempe@redhat.com> writes: > > > Now that fbcon has the skip_panic option, there is no more conflicts > > between drm_panic and fbcon. > > Remove the build time dependency, so they can be both enabled. > > > > Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com> > > --- > > drivers/gpu/drm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 6dd0016fc9cd..a22cab218004 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -107,7 +107,7 @@ config DRM_KMS_HELPER > > > > config DRM_PANIC > > bool "Display a user-friendly message when a kernel panic occurs" > > - depends on DRM && !(FRAMEBUFFER_CONSOLE && VT_CONSOLE) > > + depends on DRM > > This is great. Thanks for finding an alternative approach! I don't see any > issues this time, because there is no locking involved. But let's see what > others think about it. Looks like it should work, I did check the history of fbcon_is_active and we've used that to force/disable panic output for fbcon in the past. So I think it's the right tool. > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cheers, Sima > > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 6dd0016fc9cd..a22cab218004 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -107,7 +107,7 @@ config DRM_KMS_HELPER config DRM_PANIC bool "Display a user-friendly message when a kernel panic occurs" - depends on DRM && !(FRAMEBUFFER_CONSOLE && VT_CONSOLE) + depends on DRM select FONT_SUPPORT help Enable a drm panic handler, which will display a user-friendly message
Now that fbcon has the skip_panic option, there is no more conflicts between drm_panic and fbcon. Remove the build time dependency, so they can be both enabled. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com> --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)