| Message ID | 20241120093020.6409-2-pperego@suse.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Removed hard-coded string by using the str_true_false() helper | expand |
On Wed, Nov 20, 2024 at 10:30:20AM +0100, Paolo Perego wrote:
> Signed-off-by: Paolo Perego <pperego@suse.de>
You need to have a subsystem prefix in the subject. The subject is probably too
long as well. You need to have a commit message.
Otherwise, fine.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
On Wed, Nov 20, 2024 at 10:30:20AM +0100, Paolo Perego wrote: > Signed-off-by: Paolo Perego <pperego@suse.de> > --- > drivers/staging/fbtft/fb_ssd1351.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c > index f6db2933ebba..6736b09b2f45 100644 > --- a/drivers/staging/fbtft/fb_ssd1351.c > +++ b/drivers/staging/fbtft/fb_ssd1351.c > @@ -6,6 +6,7 @@ > #include <linux/init.h> > #include <linux/spi/spi.h> > #include <linux/delay.h> > +#include <linux/string_choices.h> > > #include "fbtft.h" > > @@ -162,7 +163,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves) > static int blank(struct fbtft_par *par, bool on) > { > fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n", > - __func__, on ? "true" : "false"); > + __func__, str_true_false(on)); > if (on) > write_reg(par, 0xAE); > else > -- > 2.47.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c index f6db2933ebba..6736b09b2f45 100644 --- a/drivers/staging/fbtft/fb_ssd1351.c +++ b/drivers/staging/fbtft/fb_ssd1351.c @@ -6,6 +6,7 @@ #include <linux/init.h> #include <linux/spi/spi.h> #include <linux/delay.h> +#include <linux/string_choices.h> #include "fbtft.h" @@ -162,7 +163,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves) static int blank(struct fbtft_par *par, bool on) { fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n", - __func__, on ? "true" : "false"); + __func__, str_true_false(on)); if (on) write_reg(par, 0xAE); else
Signed-off-by: Paolo Perego <pperego@suse.de> --- drivers/staging/fbtft/fb_ssd1351.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)