| Message ID | 20250418035023.27067-1-ericflorin.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: clean-up `else`-blocks | expand |
On Thu, Apr 17, 2025 at 08:50:23PM -0700, Eric Florin wrote: > Clean-up `else`-blocks in `hw_sm750_map` that occur after `if`-blocks that > terminate function execution. > > Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> > --- > drivers/staging/sm750fb/sm750_hw.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c > index 4bc89218c11c..64b199061d14 100644 > --- a/drivers/staging/sm750fb/sm750_hw.c > +++ b/drivers/staging/sm750fb/sm750_hw.c > @@ -55,9 +55,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) > pr_err("mmio failed\n"); > ret = -EFAULT; > goto exit; > - } else { > - pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); > } > + pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); When drivers work properly, they are "quiet". This driver is not quiet at all. So this really should be a call to dev_dbg(), right? > > sm750_dev->accel.dprBase = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; > sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; > @@ -84,9 +83,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) > pr_err("Map video memory failed\n"); > ret = -EFAULT; > goto exit; > - } else { > - pr_info("video memory vaddr = %p\n", sm750_dev->pvMem); > } > + pr_info("video memory vaddr = %p\n", sm750_dev->pvMem); Same here. thanks, greg k-h
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 4bc89218c11c..64b199061d14 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -55,9 +55,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) pr_err("mmio failed\n"); ret = -EFAULT; goto exit; - } else { - pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); } + pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); sm750_dev->accel.dprBase = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; @@ -84,9 +83,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) pr_err("Map video memory failed\n"); ret = -EFAULT; goto exit; - } else { - pr_info("video memory vaddr = %p\n", sm750_dev->pvMem); } + pr_info("video memory vaddr = %p\n", sm750_dev->pvMem); exit: return ret; }
Clean-up `else`-blocks in `hw_sm750_map` that occur after `if`-blocks that terminate function execution. Signed-off-by: Eric Florin <ericflorin.kernel@gmail.com> --- drivers/staging/sm750fb/sm750_hw.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)