From patchwork Tue May 15 16:06:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 10401569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6986601F9 for ; Tue, 15 May 2018 16:06:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B504F20453 for ; Tue, 15 May 2018 16:06:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A96BC27E71; Tue, 15 May 2018 16:06:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6901A20453 for ; Tue, 15 May 2018 16:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbeEOQGo (ORCPT ); Tue, 15 May 2018 12:06:44 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56999 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665AbeEOQGj (ORCPT ); Tue, 15 May 2018 12:06:39 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180515160637euoutp0177ad64b56e7262de5f0b9cfa804e9c73~u3RMhx8v71019210192euoutp01e; Tue, 15 May 2018 16:06:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180515160637euoutp0177ad64b56e7262de5f0b9cfa804e9c73~u3RMhx8v71019210192euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1526400398; bh=NBclHbpRwxZR8k90zt2qNi07jEw2Q1PyYf/NIsbrWAA=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=HalWmX7Glmhcvl23jtauhJdl0NHs7hcfWS927JGLiygj8dxxmk/FvlD+aYgoLjO8x /DmPwPsRhMu5ZFbkpC1z4ady6ngOHg5LzdlZ/praBQL/0NTGbkYM2EQ7M5jrfUm3eA aAOTOeo1hd7cHGG4gVwr6co+Rm2UqSCxHR/seNpc= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180515160637eucas1p23680a45fddb1684a328424661d927797~u3RL9WX-Y0683006830eucas1p22; Tue, 15 May 2018 16:06:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A7.13.10409.C850BFA5; Tue, 15 May 2018 17:06:36 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180515160636eucas1p13df40cd7b00943fb7f288cf8f5950584~u3RK2snkn2603526035eucas1p1R; Tue, 15 May 2018 16:06:36 +0000 (GMT) X-AuditID: cbfec7f5-b5fff700000028a9-04-5afb058c51fb Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 3A.D6.04183.C850BFA5; Tue, 15 May 2018 17:06:36 +0100 (BST) Received: from amdc3058.localnet ([106.120.53.102]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P8S00AKL22ZZM50@eusync3.samsung.com>; Tue, 15 May 2018 17:06:36 +0100 (BST) From: Bartlomiej Zolnierkiewicz To: Andy Shevchenko Cc: Arvind Yadav , linux-fbdev@vger.kernel.org Subject: Re: [PATCH v1] video: fbdev: pxafb: Convert to use match_string() helper Date: Tue, 15 May 2018 18:06:35 +0200 Message-id: <2633575.9g1uB693TI@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <2751679.SG41LURNrg@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsWy7djPc7o9rL+jDB7u0bLobZrOZHGtdyGz xYm+D6wOzB47Z91l95h3MtDj8ya5AOYoLpuU1JzMstQifbsEroxVPyezFpwSqph9bDtLA2MP fxcjJ4eEgInExGfbWbsYuTiEBFYwSpy5cQHK+cwo8XjXJGaYqofvLjFBJJYxSlx88p8ZwvnN KPH8+hSwKjYBK4mJ7asYQWwRAXOJdZMWsYHYzAKeEosOgnRzcggLBEvMXvOaFcRmEVCVeD3z PJjNK6Ap0X11BQuILSrgJbFlXztYPaeAlsShE/dZIGoEJX5MvscCMVNeYt/+qawQto7E2WPr GEEOkhDoYZO4dmc1I8TZLhJ35kIUSQgIS7w6voUdwpaRuDy5mwWioZlR4tuOPVB/TmCU2LNe CMK2ljh8/CLUBj6JSdumA9VwAMV5JTraoEo8JOZ9eccEYTtK/Gg4yQYJlQOMEmt33WeewCg7 C8nhs5AcPgvJ4QsYmVcxiqeWFuempxYb56WW6xUn5haX5qXrJefnbmIERvvpf8e/7mDc9yfp EKMAB6MSD2/l9V9RQqyJZcWVuYcYJTiYlUR4dxv9jBLiTUmsrEotyo8vKs1JLT7EKM3BoiTO G6dRFyUkkJ5YkpqdmlqQWgSTZeLglGpgLGCLtU14+Kpv7R/n+15sCTIXQ7y+flfuZxGqTuSq DXv+vHvatO3+ImoX9VY8nVuy54VKpmxWdTt/SM8hAaX99b7n+i++SBVtc/ugcPvXC2U+9pZF CQziGRdfOBv4X+P0Zix8MV/J0lHM53lwnmx1ur1O4K+i36HaWRM1F8h1GZZYHqrwOKfEUpyR aKjFXFScCADQgTUL8gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsVy+t/xq7o9rL+jDA79ZrXobZrOZHGtdyGz xYm+D6wOzB47Z91l95h3MtDj8ya5AOYoLpuU1JzMstQifbsEroxVPyezFpwSqph9bDtLA2MP fxcjJ4eEgInEw3eXmLoYuTiEBJYwSvxYc48VJCEk8JdRYlIPH4jNJmAlMbF9FSOILSJgLrFu 0iI2EJtZwFNi0UGQZk4OYYFgidlrXoP1sgioSryeeR7M5hXQlOi+uoIFxBYV8JLYsq8drJ5T QEvi0In7LBCLDzFKNC7cyQTRICjxY/I9FogF8hL79k9lhbC1JNbvPM40gZF/FpKyWUjKZiEp W8DIvIpRJLW0ODc9t9hIrzgxt7g0L10vOT93EyMwHLcd+7llB2PXu+BDjAIcjEo8vBdu/ooS Yk0sK67MBTqGg1lJhHe30c8oId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rznDSqjhATSE0tSs1NT C1KLYLJMHJxSDYyS1qsrFrht0pK+uEQu8FL84fiuWxIiXze8tn3N/K18+4dLp+1vPk/aXRAa eO7afpOfM4VP9/HWh/DJrrl35bPohJPsTUcPPfR54fq6Lo/z8bqPOWEijlvfczvvVNXivNfz dOnZDRzpsx+0cK5aGhy8oXzenbQLSVs6AvfMTqir5e7U/H8s/BuPEktxRqKhFnNRcSIA0hTz 2EMCAAA= X-CMS-MailID: 20180515160636eucas1p13df40cd7b00943fb7f288cf8f5950584 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180503180431epcas2p4bae1fbccd17ab5420a94987b07227f9e X-RootMTR: 20180503180431epcas2p4bae1fbccd17ab5420a94987b07227f9e References: <71f79c345eb29dcec9ac971e52873726c780e313.camel@linux.intel.com> <2751679.SG41LURNrg@amdc3058> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, May 15, 2018 02:17:35 PM Bartlomiej Zolnierkiewicz wrote: > On Tuesday, May 15, 2018 02:59:20 PM Andy Shevchenko wrote: > > On Tue, 2018-05-15 at 13:54 +0200, Bartlomiej Zolnierkiewicz wrote: > > > On Tuesday, May 15, 2018 02:35:03 PM Andy Shevchenko wrote: > > > > On Tue, 2018-05-15 at 12:37 +0200, Bartlomiej Zolnierkiewicz wrote: > > > > > On Thursday, May 03, 2018 09:04:23 PM Andy Shevchenko wrote: > > > > > > The new helper returns index of the matching string in an array. > > > > > > We are going to use it here. > > > > > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > m> > > > > > > > > > > Patch queued for 4.18, thanks. > > > > > > > > I went through it again and found a bug, the type "unknown" should > > > > be > > > > left untouched. > > > > > > Indeed, could you provide incremental fix? > > > > Is it late enough to drop patch completely? If so, I do a fix asap. > > It is already merged in publicly available tree (which is not being > rebased) so it is too late to drop it completely. OK, I fixed it myself with the patch below. Best regards, --- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From: Bartlomiej Zolnierkiewicz Subject: [PATCH] video: fbdev: pxafb: match_string() conversion fixup "unknown" lcd_types[] entry is needed for proper operation of the driver, add it back. Fixes: 6d09dfe70f8f ("video: fbdev: pxafb: Convert to use match_string() helper") Reported-by: Andy Shevchenko Cc: Arvind Yadav Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/pxafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/video/fbdev/pxafb.c =================================================================== --- a/drivers/video/fbdev/pxafb.c 2018-05-15 17:41:00.922315366 +0200 +++ b/drivers/video/fbdev/pxafb.c 2018-05-15 17:42:27.474317546 +0200 @@ -2099,7 +2099,7 @@ static void pxafb_check_options(struct d #if defined(CONFIG_OF) static const char * const lcd_types[] = { - "mono-stn", "mono-dstn", "color-stn", "color-dstn", + "unknown", "mono-stn", "mono-dstn", "color-stn", "color-dstn", "color-tft", "smart-panel", NULL };