| Message ID | 2902419.SMzMybotxA@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 27/11/15 16:33, Arnd Bergmann wrote: > The sis framebuffer driver complains with a compile-time warning > if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected: > > drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se > > This is reasonable because it doesn't work in that case, but it's > also annoying for randconfig builds and is one of the most common > warnings I'm seeing on ARM now. > > This changes the Kconfig logic to prevent the silly configuration, > by always selecting the FB_SIS_300 variant if the other one is > not set. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > Sorry for sending this twice, it looks like I forgot the fbdev list and > Tomi as recipients the first time Thanks, queued for 4.5. tomi
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e6d16d65e4e6..8a27c1443d01 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1506,6 +1506,7 @@ config FB_SIS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select FB_BOOT_VESA_SUPPORT if FB_SIS = y + select FB_SIS_300 if !FB_SIS_315 help This is the frame buffer device driver for the SiS 300, 315, 330 and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
The sis framebuffer driver complains with a compile-time warning if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected: drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se This is reasonable because it doesn't work in that case, but it's also annoying for randconfig builds and is one of the most common warnings I'm seeing on ARM now. This changes the Kconfig logic to prevent the silly configuration, by always selecting the FB_SIS_300 variant if the other one is not set. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Sorry for sending this twice, it looks like I forgot the fbdev list and Tomi as recipients the first time -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html