From patchwork Fri Nov 27 14:33:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7713581 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8580EBF90C for ; Fri, 27 Nov 2015 14:56:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8F13920616 for ; Fri, 27 Nov 2015 14:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18ABA20620 for ; Fri, 27 Nov 2015 14:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbbK0OgM (ORCPT ); Fri, 27 Nov 2015 09:36:12 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:63163 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754284AbbK0OgM (ORCPT ); Fri, 27 Nov 2015 09:36:12 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0LeyRX-1aflId3BF9-00qnJF; Fri, 27 Nov 2015 15:33:12 +0100 From: Arnd Bergmann To: linux-fbdev@vger.kernel.org, Tomi Valkeinen Cc: Thomas Winischhofer , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] fbdev: sis: enforce selection of at least one backend Date: Fri, 27 Nov 2015 15:33:11 +0100 Message-ID: <2902419.SMzMybotxA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:sryxOwD7SJEj8BDtbRZT033VKjmuGfXlFjGq63QSPPmOk1TllnF HBI0iqoVQJLsOAtoDbha9Q59oliVl9KRseLWLhMrptnSlxGqpdsKiBKi+mJDGNS8LHicy13 Bl5WYA1TbjdhqDTPUYf8o9ZDU9l+Ub3ivTLcaEg1M6J36aNIEZ898vrjEVnvN+kmByst8gy VkfGYcPtvV9dDaG52yrlQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:SZzwooX6WnM=:ZZwoOzOS8ZJe1/kwPiz9Y5 atR4TMzehDmHvVzjBvv/ph89bdlf2hfV8yXUXHzQMQ4NxzyOXPXo8F+7Sn+Se/i9fFXBN3ndh WeiqoGh4yfgLnqR+WUN8qprZ21/UqTKbN4g7OcJlYMrnX7/g62eJrNwMvGZZDduMmZOLhYW2r L8Gzwy8+d+TURyCHOSDuDQHhVj82IGsVmFZPurtfWL4BDXuKQlPYb+MWtO/yFhZGC/6skNY/e r0iwMX2MafNPgsn1xS3NYLJQx7vq9YT08rIJ1LYUQJS7soSBqE+Mz6tp/ixhfPlwPcvkwD9B+ mP9x0H61oUpTsMClqCHKRhNGSxeosUKCfEG0jpRjcnqJBV2g3HE5lBebmYz0BKq0WWE8hFJTj eWUKXn4ZlXygTDU/NK7+Y9Q8S2keVBRhijobk7lrt2Vbkc6tvjzHe3Yp28avO/4yhN9ZXs5vQ fatl3ASObmWmVUirNsEB14RNs7ignD9RNuNnDFvywuUl3PtOgnuJKnWV4LrQ15sLryy7oRmvr mm9ZZJht72lKm5eVR2jMvHzpagfFzvy/xbwIMXoCzcgSrqhcn6NcyF633Mq985pe9qdoq2x7M GCRQjpWrm2xUvU1RFSuPT8EpwSz2bWyAlrJLCz9cUvDWjKM7mf11KCCJ9jk55734IJ3TtXncq xUbvTyEvX0/eGQ43TfVXfIDy8pmWuiMofYxo3VvLuM4QIHx9a5GNMhu9vVRf/Kg60mi2smkJX ij5+ZSlKFvt/9XEU Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The sis framebuffer driver complains with a compile-time warning if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected: drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se This is reasonable because it doesn't work in that case, but it's also annoying for randconfig builds and is one of the most common warnings I'm seeing on ARM now. This changes the Kconfig logic to prevent the silly configuration, by always selecting the FB_SIS_300 variant if the other one is not set. Signed-off-by: Arnd Bergmann --- Sorry for sending this twice, it looks like I forgot the fbdev list and Tomi as recipients the first time -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e6d16d65e4e6..8a27c1443d01 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1506,6 +1506,7 @@ config FB_SIS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select FB_BOOT_VESA_SUPPORT if FB_SIS = y + select FB_SIS_300 if !FB_SIS_315 help This is the frame buffer device driver for the SiS 300, 315, 330 and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.