From patchwork Fri Jul 29 12:20:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stanley X-Patchwork-Id: 1020542 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6TCKbrk015793 for ; Fri, 29 Jul 2011 12:20:37 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755975Ab1G2MUg (ORCPT ); Fri, 29 Jul 2011 08:20:36 -0400 Received: from nm30-vm0.access.bullet.mail.mud.yahoo.com ([66.94.237.86]:20333 "HELO nm30-vm0.access.bullet.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755804Ab1G2MUg (ORCPT ); Fri, 29 Jul 2011 08:20:36 -0400 Received: from [66.94.237.127] by nm30.access.bullet.mail.mud.yahoo.com with NNFMP; 29 Jul 2011 12:20:35 -0000 Received: from [66.94.237.116] by tm2.access.bullet.mail.mud.yahoo.com with NNFMP; 29 Jul 2011 12:20:35 -0000 Received: from [127.0.0.1] by omp1021.access.mail.mud.yahoo.com with NNFMP; 29 Jul 2011 12:20:35 -0000 X-Yahoo-Newman-Id: 600652.95795.bm@omp1021.access.mail.mud.yahoo.com Received: (qmail 36268 invoked from network); 29 Jul 2011 12:20:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1311942035; bh=o9/kKLkd65DlmOkybe3vyU28zRhAQ721jNE9/pNVdW8=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=sTxalEeMGKx+h3KsFA8i/tGSTf8U0Xt7eV7BFOwFqP9bdA6mKoBUV8U1WDio07gOK05GPwpX2HXychdmlzDLyErxjL1KN/AH7kIYdH+CCYWcPCvA3MmhkGK8JWu33XPGUh7PNlzs6CoT9UAOaNRsTMCUQhdsgRr0Dqe1uRJ60kg= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: n.EtJC4VM1m3bkH2oIcFbDeSlG5NJMsq6_SsnV_X5uQtx_6 ju_U93Tcv4vzmiXfR_q1nPI1e45VGX68qzlOreWWQ.SGuFB8ipxy5ehWSo.F 4sHmy9jkm.9Sxf0QZBIR8kxzrdxmw6shiZVgc6b7npDJRopfMPVcYspt1z3b Jlk0KKKmf_AX4F7GggTEHaZEW1bPLcICAs9r1dkKAJ.gLhdb5qf23VOFgud_ zLAFtJNZiDWDfMbKkswjBmlFa7AYiLZsqVMvQqPBvcAihZ1wjej_CVWdh9bw k7q242Xb4sSg.MUe3qNYGQ_RWEWJ4I2I54w2wazHPbRTWXX4fXA-- X-Yahoo-SMTP: vMdlIiuswBDCrJd.52t_ytI_iaWTSggVja27tjT2P0U0lhW1 Received: from [192.168.2.9] (jpsinthemix@68.239.107.235 with plain) by smtp103.vzn.mail.bf1.yahoo.com with SMTP; 29 Jul 2011 05:20:35 -0700 PDT Message-ID: <4E32A590.5040504@verizon.net> Date: Fri, 29 Jul 2011 08:20:32 -0400 From: John Stanley User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: Andrew Morton CC: bugme-daemon@bugzilla.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [Bugme-new] [Bug 39842] New: savagefb.h CARD SERIES definition typo References: <20110728162752.3a4602e4.akpm@linux-foundation.org> In-Reply-To: <20110728162752.3a4602e4.akpm@linux-foundation.org> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 29 Jul 2011 12:20:37 +0000 (UTC) Replying to all.. I have also attached the one-line patch. thanks, John On 07/28/2011 07:27 PM, Andrew Morton wrote: > (switched to email. Please respond via emailed reply-to-all, not via the > bugzilla web interface). > > On Sat, 23 Jul 2011 10:20:41 GMT > bugzilla-daemon@bugzilla.kernel.org wrote: > >> https://bugzilla.kernel.org/show_bug.cgi?id=39842 >> >> Summary: savagefb.h CARD SERIES definition typo >> Product: Drivers >> Version: 2.5 >> Kernel Version: 3.0.0 >> Platform: All >> OS/Version: Linux >> Tree: Mainline >> Status: NEW >> Severity: normal >> Priority: P1 >> Component: Video(Other) >> AssignedTo: drivers_video-other@kernel-bugs.osdl.org >> ReportedBy: jpsinthemix@verizon.net >> Regression: Yes >> >> >> I have an old T22 Thinkpad with integrated Savage/IX-MV video. As of linux-3.0, >> the video is non-functional; the PC either hard hangs immediately or has >> totally garbled video, and then hard hangs, as soon as I attempt to edit a file >> or cat a file with more than a screen-full of text. The foregoing details are >> actually not important any more as in looking at the code changes I discovered >> a typo in linux-3.0.0/drivers/video/savage/savagefb.h and have applied the >> following patch to fix the issue: >> >> --- linux-3.0.0.old/drivers/video/savage/savagefb.h 2011-07-21 >> 22:17:23.000000000 -0400 >> +++ linux-3.0.0.new/drivers/video/savage/savagefb.h 2011-07-23 >> 05:13:33.801215293 -0400 >> @@ -55,7 +55,7 @@ >> >> #define S3_SAVAGE3D_SERIES(chip) ((chip>=S3_SAVAGE3D)&& >> (chip<=S3_SAVAGE_MX)) >> >> -#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4) || >> (chip<=S3_PROSAVAGEDDR)) >> +#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4)&& >> (chip<=S3_PROSAVAGEDDR)) >> >> #define S3_SAVAGE_MOBILE_SERIES(chip) ((chip==S3_SAVAGE_MX) || >> (chip==S3_SUPERSAVAGE)) >> >> >> P.S. Many, many thanks for lifting the 800x600 resolution limit! I've been >> using a patch/hack to bump the limit to 1024x768 for an very long time... >> John > Please resend that fix as a formal signed-off-patch as a reply-to-all > to this email? Documentation/SubmittingPatches has some tips. > > Thanks. > > --- linux-3.0.0.old/drivers/video/savage/savagefb.h 2011-07-21 22:17:23.000000000 -0400 +++ linux-3.0.0.new/drivers/video/savage/savagefb.h 2011-07-23 05:13:33.801215293 -0400 @@ -55,7 +55,7 @@ #define S3_SAVAGE3D_SERIES(chip) ((chip>=S3_SAVAGE3D) && (chip<=S3_SAVAGE_MX)) -#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4) || (chip<=S3_PROSAVAGEDDR)) +#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4) && (chip<=S3_PROSAVAGEDDR)) #define S3_SAVAGE_MOBILE_SERIES(chip) ((chip==S3_SAVAGE_MX) || (chip==S3_SUPERSAVAGE))