From patchwork Fri Jun 7 08:10:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hector Palacios X-Patchwork-Id: 2684931 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 4ACDFDFB78 for ; Fri, 7 Jun 2013 08:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633Ab3FGIRg (ORCPT ); Fri, 7 Jun 2013 04:17:36 -0400 Received: from mail1.bemta7.messagelabs.com ([216.82.254.111]:41524 "EHLO mail1.bemta7.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808Ab3FGIRd (ORCPT ); Fri, 7 Jun 2013 04:17:33 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 07 Jun 2013 04:17:33 EDT Received: from [216.82.254.195:45827] by server-15.bemta-7.messagelabs.com id 3A/D3-24154-C8591B15; Fri, 07 Jun 2013 08:10:52 +0000 X-Env-Sender: Hector.Palacios@digi.com X-Msg-Ref: server-3.tower-200.messagelabs.com!1370592651!12199681!1 X-Originating-IP: [66.77.174.13] X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6593 invoked from network); 7 Jun 2013 08:10:52 -0000 Received: from mail.mx1.digi.com (HELO mcl-sms-ns1.digi.com) (66.77.174.13) by server-3.tower-200.messagelabs.com with RC4-SHA encrypted SMTP; 7 Jun 2013 08:10:52 -0000 Received: from MCL-VMS-XCH01.digi.com (10.5.8.49) by mail.mx1.digi.com (172.16.1.13) with Microsoft SMTP Server (TLS) id 8.3.298.1; Fri, 7 Jun 2013 03:10:45 -0500 Received: from dor-sms-exch01.digi.com (10.49.8.100) by MCL-VMS-XCH01.digi.com (10.5.8.49) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 7 Jun 2013 03:10:51 -0500 Received: from [10.101.1.187] (10.101.1.187) by dor-sms-exch01.digi.com (10.49.8.100) with Microsoft SMTP Server (TLS) id 8.3.298.1; Fri, 7 Jun 2013 10:10:49 +0200 Message-ID: <51B1957F.40104@digi.com> Date: Fri, 7 Jun 2013 10:10:39 +0200 From: Hector Palacios Organization: Digi International User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: , CC: "maxime.ripard@free-electrons.com" , Juergen Beisert , "linux-arm-kernel@lists.infradead.org" , "fabio.estevam@freescale.com" , "brian@crystalfontz.com" , "linux-kernel@vger.kernel.org" , Alexandre Belloni , "shawn.guo@linaro.org" Subject: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp References: <519E03B0.1080006@digi.com> <519F4435.5010703@digi.com> <201305241300.25461.jbe@pengutronix.de> <201305241533.19941.jbe@pengutronix.de> <20130607072103.GF14209@lukather> <51B18BA0.50506@digi.com> <20130607074200.GG14209@lukather> In-Reply-To: <20130607074200.GG14209@lukather> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org For a combination of 18bit LCD data bus width and a color mode of 32bpp, the driver was setting the color mapping to rgb666, which is wrong, as the color in memory realy has an rgb888 layout. This patch also removes the setting of flag CTRL_DF24 that makes the driver dimiss the upper 2 bits when handling 32/24bpp colors in a diplay with 18bit data bus width. This flag made true color images display wrong in such configurations. Finally, the color mapping rgb666 has also been removed as nobody is using it and high level applications like Qt5 cannot work with it either. Reference: https://lkml.org/lkml/2013/5/23/220 Signed-off-by: Hector Palacios Acked-by: Juergen Beisert Acked-by: Maxime Ripard --- drivers/video/mxsfb.c | 26 -------------------------- 1 file changed, 26 deletions(-) -- 1.8.3 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 21223d4..d2c5105 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -239,24 +239,6 @@ static const struct fb_bitfield def_rgb565[] = { } }; -static const struct fb_bitfield def_rgb666[] = { - [RED] = { - .offset = 16, - .length = 6, - }, - [GREEN] = { - .offset = 8, - .length = 6, - }, - [BLUE] = { - .offset = 0, - .length = 6, - }, - [TRANSP] = { /* no support for transparency */ - .length = 0, - } -}; - static const struct fb_bitfield def_rgb888[] = { [RED] = { .offset = 16, @@ -309,9 +291,6 @@ static int mxsfb_check_var(struct fb_var_screeninfo *var, break; case STMLCDIF_16BIT: case STMLCDIF_18BIT: - /* 24 bit to 18 bit mapping */ - rgb = def_rgb666; - break; case STMLCDIF_24BIT: /* real 24 bit */ rgb = def_rgb888; @@ -453,11 +432,6 @@ static int mxsfb_set_par(struct fb_info *fb_info) return -EINVAL; case STMLCDIF_16BIT: case STMLCDIF_18BIT: - /* 24 bit to 18 bit mapping */ - ctrl |= CTRL_DF24; /* ignore the upper 2 bits in - * each colour component - */ - break; case STMLCDIF_24BIT: /* real 24 bit */ break;