From patchwork Wed Jun 26 21:30:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Warren X-Patchwork-Id: 2788601 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 410EAC0AB1 for ; Wed, 26 Jun 2013 21:30:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6745B20349 for ; Wed, 26 Jun 2013 21:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95A4120358 for ; Wed, 26 Jun 2013 21:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173Ab3FZVaU (ORCPT ); Wed, 26 Jun 2013 17:30:20 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:33428 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005Ab3FZVaS (ORCPT ); Wed, 26 Jun 2013 17:30:18 -0400 Received: from severn.wwwdotorg.org (unknown [192.168.65.5]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by avon.wwwdotorg.org (Postfix) with ESMTPS id A08446348; Wed, 26 Jun 2013 15:40:21 -0600 (MDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by severn.wwwdotorg.org (Postfix) with ESMTPSA id 47E02E462A; Wed, 26 Jun 2013 15:30:16 -0600 (MDT) Message-ID: <51CB5D67.3090701@wwwdotorg.org> Date: Wed, 26 Jun 2013 15:30:15 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: David Herrmann CC: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Airlie , linux-fbdev@vger.kernel.org, Stephen Warren , Olof Johansson Subject: Re: [RFC 0/6] SimpleDRM Driver (was: dvbe driver) References: <1372112849-670-1-git-send-email-dh.herrmann@gmail.com> In-Reply-To: <1372112849-670-1-git-send-email-dh.herrmann@gmail.com> X-Enigmail-Version: 1.4.6 X-Virus-Scanned: clamav-milter 0.97.7 at avon.wwwdotorg.org X-Virus-Status: Clean Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/24/2013 04:27 PM, David Herrmann wrote: > Hi > > This is my second revision of the dvbe driver. I renamed it to SimpleDRM to > show the resemblence with the recently introduced simplefb.c fbdev driver. The > driver is supposed to be the most basic DRM driver similar to efifb.c, vesafb.c, > offb.c, simplefb.c, ... > It provides a single virtual CRTC+encoder+connector and allows user-space to > create one dumb-buffer at a time and attach it. > > The setup changed slightly. It no longer uses shadow buffers but instead maps > the framebuffer directly into userspace. Furthermore, a new infrastructure is > used to unload firmware drivers during real hardware drivers probe cycles. Only > nouveau was changed to use it, yet. > > I still have an odd problem when unloading DRM drivers (not just SimpleDRM) with > an fbdev fallback. If I call printk() directly after unregister_framebufer(), I > get a NULL-deref somewhere in the VT layer (most times hide_cursor()). I haven't > figured out exactly where that happens, but I am also very reluctant to spend > more time debugging the VT layer. I tested this on a Tegra ARM system, and it basically worked. I have one question: With the simplefb driver, and console=tty1 on the kernel command-line, I see both the penguins logo and Linux's boot messages on the LCD panel that's hooked up through simplefb. However, with simpledrm, I only see the penguins logo, but no boot messages. Is that expected? How would I solve that if so? Note: I needed to apply the following patch to get it to compile: --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/simpledrm/simpledrm_fbdev.c b/drivers/gpu/drm/simpledrm/simpledrm_fbdev.c index 40a2696..39885c8 100644 --- a/drivers/gpu/drm/simpledrm/simpledrm_fbdev.c +++ b/drivers/gpu/drm/simpledrm/simpledrm_fbdev.c @@ -159,7 +159,7 @@ void sdrm_fbdev_cleanup(struct sdrm_device *sdrm) { struct fb_info *info; - if (!sdrm->info) + if (!sdrm->fbdev) return; dev_info(sdrm->ddev->dev, "fbdev cleanup\n");