From patchwork Mon Oct 6 12:18:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 5036641 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 86161C11AB for ; Mon, 6 Oct 2014 12:19:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D701D20149 for ; Mon, 6 Oct 2014 12:19:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAFB82013A for ; Mon, 6 Oct 2014 12:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbaJFMTT (ORCPT ); Mon, 6 Oct 2014 08:19:19 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:57761 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbaJFMTS (ORCPT ); Mon, 6 Oct 2014 08:19:18 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s96CJ1ts005812; Mon, 6 Oct 2014 07:19:01 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s96CJ1iv019383; Mon, 6 Oct 2014 07:19:01 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Mon, 6 Oct 2014 07:19:00 -0500 Received: from [172.22.232.122] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s96CIwJ0016138; Mon, 6 Oct 2014 07:18:58 -0500 Message-ID: <543288B1.8060700@ti.com> Date: Mon, 6 Oct 2014 15:18:57 +0300 From: Tomi Valkeinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Laurent Pinchart , Arnd Bergmann CC: Steffen Trumtrar , Philipp Zabel , Jean-Christophe Plagniol-Villard , Subject: Re: [PATCH] videomode: provide dummy of_get_display_timing helper References: <1957575.to7BPgiTer@wuerfel> <1509068.h69CH2ppLS@avalon> In-Reply-To: <1509068.h69CH2ppLS@avalon> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY, URIBL_RHS_DOB autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 29/09/14 23:43, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > On Monday 29 September 2014 18:00:33 Arnd Bergmann wrote: >> If CONFIG_OF is disabled but we build any driver that tries to >> use of_get_display_timing, we get this link error: >> >> ERROR: "of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] >> undefined! >> >> This adds an empty inline function as an alternative, to avoid changing >> each driver using this function when we want to build them without >> CONFIG_OF. >> >> Signed-off-by: Arnd Bergmann > > Shouldn't empty functions also be defined for of_get_display_timings and > of_display_timings_exist ? I took the liberty of updating the patch. Btw, if I just select "Renesas ARM SoCs (non-multiplatform)", without any of the "Renesas ARM SoCs System Type" items, I get compile prints like "warning: "__LINUX_ARM_ARCH__" is not defined". And if I select only "ARCH_SH7372", I get "arm-linux-gnueabihf-ld: no machine record defined". In any case, I was able to compile the drivers/gpu/drm/rcar-du/rcar-du-drm.ko, so I believe the patch is ok. Tomi From bd1815e4bff50b5569d1989aaf9096d14ce71d12 Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Mon, 6 Oct 2014 15:03:57 +0300 Subject: [PATCH] videomode: provide dummy inline functions for !CONFIG_OF If CONFIG_OF is disabled but we build any driver that tries to use of_get_display_timing, we get this link error: ERROR: "of_get_display_timing" [drivers/gpu/drm/rcar-du/rcar-du-drm.ko] undefined! This adds an empty inline function as an alternative, to avoid changing each driver using this function when we want to build them without CONFIG_OF. Reported-by: Arnd Bergmann Signed-off-by: Tomi Valkeinen --- include/video/of_display_timing.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h index 79e6697af6cf..3a180c097e7c 100644 --- a/include/video/of_display_timing.h +++ b/include/video/of_display_timing.h @@ -15,9 +15,26 @@ struct display_timings; #define OF_USE_NATIVE_MODE -1 +#ifdef CONFIG_OF int of_get_display_timing(struct device_node *np, const char *name, struct display_timing *dt); struct display_timings *of_get_display_timings(struct device_node *np); int of_display_timings_exist(struct device_node *np); +#else +static inline int of_get_display_timing(struct device_node *np, const char *name, + struct display_timing *dt) +{ + return -ENOSYS; +} +static inline struct display_timings *of_get_display_timings(struct device_node *np) +{ + return NULL; +} +static inline int of_display_timings_exist(struct device_node *np) +{ + return -ENOSYS; +} + +#endif #endif