| Message ID | 843b063c-ee4a-4e17-add6-75e2cc82c2f4@moroto.mountain (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fbdev: omapfb: fix some error codes | expand |
On 10/16/23 13:19, Dan Carpenter wrote: > Return negative -ENXIO instead of positive ENXIO. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> applied. Thanks! Helge > --- > No fixes tag because the caller doesn't check for errors. > > drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c > index f28cb90947a3..42c96f1cfc93 100644 > --- a/drivers/video/fbdev/omap/omapfb_main.c > +++ b/drivers/video/fbdev/omap/omapfb_main.c > @@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev, > } > fbdev->int_irq = platform_get_irq(pdev, 0); > if (fbdev->int_irq < 0) { > - r = ENXIO; > + r = -ENXIO; > goto cleanup; > } > > fbdev->ext_irq = platform_get_irq(pdev, 1); > if (fbdev->ext_irq < 0) { > - r = ENXIO; > + r = -ENXIO; > goto cleanup; > } >
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index f28cb90947a3..42c96f1cfc93 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev, } fbdev->int_irq = platform_get_irq(pdev, 0); if (fbdev->int_irq < 0) { - r = ENXIO; + r = -ENXIO; goto cleanup; } fbdev->ext_irq = platform_get_irq(pdev, 1); if (fbdev->ext_irq < 0) { - r = ENXIO; + r = -ENXIO; goto cleanup; }
Return negative -ENXIO instead of positive ENXIO. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- No fixes tag because the caller doesn't check for errors. drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)