From patchwork Wed Nov 16 06:15:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 9430935 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73AB860469 for ; Wed, 16 Nov 2016 06:15:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A9D1286B9 for ; Wed, 16 Nov 2016 06:15:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D96328DC3; Wed, 16 Nov 2016 06:15:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3B52286B9 for ; Wed, 16 Nov 2016 06:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752502AbcKPGPs (ORCPT ); Wed, 16 Nov 2016 01:15:48 -0500 Received: from ozlabs.org ([103.22.144.67]:55251 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbcKPGPr (ORCPT ); Wed, 16 Nov 2016 01:15:47 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 3tJYsY42mYz9srZ; Wed, 16 Nov 2016 17:15:45 +1100 (AEDT) From: Michael Ellerman To: Tomi Valkeinen , Linus Torvalds Cc: linux-fbdev , "linux-kernel\@vger.kernel.org" , Mathieu Malaterre Subject: Re: [GIT PULL] fbdev fixes for 4.9 In-Reply-To: References: User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 16 Nov 2016 17:15:40 +1100 Message-ID: <87r36cx84z.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tomi Valkeinen writes: > [ Unknown signature status ] > On 14/11/16 18:25, Linus Torvalds wrote: >> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen wrote: >>> >>> Please pull two fbdev fixes for 4.9. >> >> No. >> >> This has obviously never even been test-compiled. It introduces two >> new annoying warnings. > > Sorry about that. I dropped the patch for now and here's a new pull request. > > I did test compile, and I would have noticed errors but I missed the warnings > (I blame the flu...). I need to improve my testing methods, but I couldn't find > a way to add -Werror to kernel builds. You can turn it on per-directory, eg: cheers --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile index ee8c81405a7f..2ee96810d26d 100644 --- a/drivers/video/fbdev/Makefile +++ b/drivers/video/fbdev/Makefile @@ -4,6 +4,8 @@ # Each configuration option enables a list of files. +subdir-ccflags-y := -Werror + obj-y += core/ obj-$(CONFIG_FB_MACMODES) += macmodes.o