diff mbox

fbdev: sh_mobile_lcdc: fixup B side hsync adjust settings

Message ID 87wqtmmp59.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kuninori Morimoto March 5, 2013, 4:44 a.m. UTC 
The lcdc B side horizon output is shifted if sh_mobile_lcdc_pan() was called,
since driver didn't care LDHAJR mirror.
This patch fixup this issue

Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/video/sh_mobile_lcdcfb.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Magnus Damm March 5, 2013, 4:47 a.m. UTC | #1 
Hi Morimoto-san,

On Tue, Mar 5, 2013 at 1:44 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> The lcdc B side horizon output is shifted if sh_mobile_lcdc_pan() was called,
> since driver didn't care LDHAJR mirror.
> This patch fixup this issue
>
> Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for this. Would it be possible for you to include information
about which SoC and board you have tested this on?

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto March 5, 2013, 5 a.m. UTC | #2 
Hi Magnus

> > The lcdc B side horizon output is shifted if sh_mobile_lcdc_pan() was called,
> > since driver didn't care LDHAJR mirror.
> > This patch fixup this issue
> >
> > Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> > Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Thanks for this. Would it be possible for you to include information
> about which SoC and board you have tested this on?

I see. will fix in v2 patch
Thank you

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 63203ac..0264704 100644
--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c
@@ -858,6 +858,7 @@  static void sh_mobile_lcdc_geometry(struct sh_mobile_lcdc_chan *ch)
 	tmp = ((mode->xres & 7) << 24) | ((display_h_total & 7) << 16)
 	    | ((mode->hsync_len & 7) << 8) | (hsync_pos & 7);
 	lcdc_write_chan(ch, LDHAJR, tmp);
+	lcdc_write_chan_mirror(ch, LDHAJR, tmp);
 }
 
 static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)