From patchwork Thu Jan 24 08:47:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Afzal Mohammed X-Patchwork-Id: 2030001 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id DC2C9DF264 for ; Thu, 24 Jan 2013 08:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716Ab3AXIr2 (ORCPT ); Thu, 24 Jan 2013 03:47:28 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:47971 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540Ab3AXIr1 (ORCPT ); Thu, 24 Jan 2013 03:47:27 -0500 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r0O8l7ZP018805; Thu, 24 Jan 2013 02:47:08 -0600 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r0O8l3JU005027; Thu, 24 Jan 2013 14:17:03 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE71.ent.ti.com ([fe80::692c:15fd:9507:b54%21]) with mapi id 14.01.0323.003; Thu, 24 Jan 2013 14:17:03 +0530 From: "Mohammed, Afzal" To: Steffen Trumtrar , Leela Krishna Amudala CC: "linux-fbdev@vger.kernel.org" , David Airlie , "devicetree-discuss@lists.ozlabs.org" , Florian Tobias Schandinat , "dri-devel@lists.freedesktop.org" , Rob Clark , "Valkeinen, Tomi" , Laurent Pinchart , "kernel@pengutronix.de" , Guennady Liakhovetski , "linux-media@vger.kernel.org" Subject: RE: [PATCH v16 RESEND 0/7] of: add display helper Thread-Topic: [PATCH v16 RESEND 0/7] of: add display helper Thread-Index: AQHN98fBEPUZVy7Kc0Ovs8HDihBpTZhViVAAgAC+VgCAAVAPAIAAM7kAgABhCRA= Date: Thu, 24 Jan 2013 08:47:02 +0000 Message-ID: References: <1358766482-6275-1-git-send-email-s.trumtrar@pengutronix.de> <20130123091202.GA11828@pengutronix.de> <20130124081958.GA28406@pengutronix.de> In-Reply-To: <20130124081958.GA28406@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.162.25] MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Steffen, On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote: > Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4. As you are going to have a v17, if you can fold the diff[1] (that I mentioned earlier) into the patch, "fbmon: add of_videomode helpers", it would be helpful. Regards Afzal [1] diff --git a/include/linux/fb.h b/include/linux/fb.h index 58b9860..0ce30d1 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -716,9 +716,19 @@ extern void fb_destroy_modedb(struct fb_videomode *modedb); extern int fb_find_mode_cvt(struct fb_videomode *mode, int margins, int rb); extern unsigned char *fb_ddc_read(struct i2c_adapter *adapter); +#if defined(CONFIG_OF_VIDEOMODE) && defined(CONFIG_FB_MODE_HELPERS) extern int of_get_fb_videomode(struct device_node *np, struct fb_videomode *fb, int index); +#else +static inline int of_get_fb_videomode(struct device_node *np, + struct fb_videomode *fb, + int index) +{ + return -EINVAL; +} +#endif + extern int fb_videomode_from_videomode(const struct videomode *vm, struct fb_videomode *fbmode);