From patchwork Mon Jun 25 13:29:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 10486131 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 814256031B for ; Mon, 25 Jun 2018 13:29:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 730B227E5A for ; Mon, 25 Jun 2018 13:29:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5AF2627F4B; Mon, 25 Jun 2018 13:29:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C24227EE2 for ; Mon, 25 Jun 2018 13:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755534AbeFYN3a (ORCPT ); Mon, 25 Jun 2018 09:29:30 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36455 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755461AbeFYN33 (ORCPT ); Mon, 25 Jun 2018 09:29:29 -0400 Received: by mail-wr0-f194.google.com with SMTP id f16-v6so13713234wrm.3 for ; Mon, 25 Jun 2018 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=VoF7uPmjIBf11HPtLKAwFxbjtVOFysmGXONtW6WV4HQ=; b=qAerjVjBEl1zhQquuvJa0C/YAg5RGt9drNrt0LsSjY44vWIfQJO0umSvitlyUMlS63 vN/ko2L43FdPCN8iUsb8L0niT1RVB9HU/uYJK1CsoRpBVI7fZoe6yvDszaTLei8pqvVI Yg0o2bPiuJN5S13bOX9wvVTZ/yit58TURuMEs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VoF7uPmjIBf11HPtLKAwFxbjtVOFysmGXONtW6WV4HQ=; b=N+Y2HrTMSO3vE7EzdMOOeMz2/49WCh6ZeqWCVkn75EWOYoymzr2ElYdsV0zpkHe3wX 11IXB7KrZhU/G5Y+VLyiWCgkDuMei6tnNc+4oSRzPNv6SrhBfcRxy8QUMjxs/OC2boWN P7a3r0xUOQDYFHee+MrC4QZL11tS8+kHM2KW9TlVoPKk/1oFeikUin/4PjZSgUEhd5CC GPa3Y0cx9zrma7ov7Ypqkas4V6gjCQNHRBHCIMb2pISJIDr4Qcy5TFLsATz0eusv9N+t 7b903QXrpeRvPivSEySZ2n6ixXuvWBvekLaLfYh0C7D90F0zMsjJnCk0gBRIqQo4aCBW ROlA== X-Gm-Message-State: APt69E01sWgHCMYF3eEDaepaB/Ygf4v7GP5OZY77Hwa6ZihBuBvys9yM cTUBf4jyzHXDgXslerI5ffjv3kfqTjzOJK7L9eHE2g== X-Google-Smtp-Source: AAOMgpegE1gYajATfqi0ja/aDVLBtxzpUlNPjz6xtPIkx+f/XvtlAqlmIV3Sj7ncQBHUrNO5qXQGRYOfHdQbbJOgLeg= X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr6744230wri.146.1529933368487; Mon, 25 Jun 2018 06:29:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:8684:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 06:29:27 -0700 (PDT) From: Michael Nazzareno Trimarchi Date: Mon, 25 Jun 2018 15:29:27 +0200 Message-ID: Subject: simple-framebuffer enquire To: Hans de Goede Cc: Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, LKML Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Hans In order to let it even registered the simplefb I have added this change. According on what I understand from the code seems that this is the way to acquire memory with the correct attribute Another question is aliases { display0 = &lcdif; }; chosen { #address-cells = <1>; #size-cells = <1>; ranges; stdout-path = &uart1; framebuffer0: framebuffer@86fd6080 { compatible = "simple-framebuffer"; reg = <0x86fd6080 (480 * 272 * 4)>; width = <480>; height = <272>; stride = <(480 * 4)>; format = "a8r8g8b8"; clocks = <&clks IMX6UL_CLK_LCDIF_PIX>, <&clks IMX6UL_CLK_LCDIF_APB>, <&clks IMX6UL_CLK_DUMMY>, <&clks IMX6UL_CLK_GPIO3>, <&clks IMX6UL_CLK_GPIO4>; nshut-supply = <®_lcd_nshut>; nreset-supply = <®_lcd_nreset>; display = <&lcdif>; }; }; }; How do you ensure that regulators that are bind to gpios can be maintain during boot? A small minor comment is how to automatic switch then to normal framebuffer. Anyway seems that #address-cells = <1>; #size-cells = <1>; ranges; are mandatory and they are in the dts documentation. Best regards Michael --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index a3c44ec..7e61ce3 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -466,8 +466,8 @@ static int simplefb_probe(struct platform_device *pdev) info->fbops = &simplefb_ops; info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; - info->screen_base = ioremap_wc(info->fix.smem_start, - info->fix.smem_len); + info->screen_base = arch_memremap_wb(info->fix.smem_start, + info->fix.smem_len); if (!info->screen_base) { ret = -ENOMEM; goto error_fb_release;