From patchwork Sun Oct 21 12:54:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1622501 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id CA67BDFFF1 for ; Sun, 21 Oct 2012 12:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586Ab2JUMy2 (ORCPT ); Sun, 21 Oct 2012 08:54:28 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:61733 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563Ab2JUMy1 (ORCPT ); Sun, 21 Oct 2012 08:54:27 -0400 Received: by mail-qc0-f174.google.com with SMTP id o22so1010064qcr.19 for ; Sun, 21 Oct 2012 05:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=AW8MN7RQP3U6yWz8vWl0pHpglppkSaTfHgRsh1nYSRQ=; b=ZPHRshYfPmRM0k1EuzhoqSKweRKRWiBZ5XlI20R6nslSq3UWkbsak5UrMrIELWjqqg HcU2tCkKJUvKUGTBhO1bZ70t2wyaGml2TKn1akE81RDwEr9CpKam7u4PjBlIwjmyB8Yy wtg4Wo6ROdOqomMR2/MSgy5l8Yl+P3oyWV1QgU5OXZumt8qirpFjCOFSpB3xB71NJKh2 nH2WTuqCOxBu6Ip5CRwhI97whDLA1DPXTVZl8yvk/DreefA13CUPRgAjav9Ha9nhXvcT VzAtJoGBB/sd51wzgP4/jBjD3o+L/0XfgXXHJPTt16dou/KVRtsvgzMOYA6/Gk8vYfNT Iofw== MIME-Version: 1.0 Received: by 10.49.63.97 with SMTP id f1mr3513851qes.4.1350824066864; Sun, 21 Oct 2012 05:54:26 -0700 (PDT) Received: by 10.229.134.205 with HTTP; Sun, 21 Oct 2012 05:54:26 -0700 (PDT) Date: Sun, 21 Oct 2012 20:54:26 +0800 Message-ID: Subject: [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs() From: Wei Yongjun To: tomi.valkeinen@ti.com, FlorianSchandinat@gmx.de Cc: yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org From: Wei Yongjun Add the missing unlock on the error handling path in function hdmi_dump_regs(). Signed-off-by: Wei Yongjun Reviewed-by: Sumit Semwal --- no test --- drivers/video/omap2/dss/hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index a48a7dd..8c9b8b3 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s) { mutex_lock(&hdmi.lock); - if (hdmi_runtime_get()) + if (hdmi_runtime_get()) { + mutex_unlock(&hdmi.lock); return; + } hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s); hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);