| Message ID | Z6xREbLLtexX4_uh@michael-devbox (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided | expand |
Hi Am 12.02.25 um 08:43 schrieb Michael Anckaert: > Replace architecture-specific defines with CONFIG_X86 checks to improve > portability and adhere to kernel coding standards. > > Fixes checkpatch warning: > - CHECK: architecture specific defines should be avoided. > > Changes made: > - Using CONFIG_X86 instead of i386 and x86. > > Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 02860d3ec365..67a2f60440ca 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param) > reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE); > poke32(VGA_CONFIGURATION, reg); > } else { > -#if defined(__i386__) || defined(__x86_64__) > +#ifdef CONFIG_X86 > /* set graphic mode via IO method */ > outb_p(0x88, 0x3d4); > outb_p(0x06, 0x3d5); Maybe move the '} else {' into the ifdef to avoid the possibly empty else branch. I also wonder why this is only being done on x86. There are other systems with VGA. In any case Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 02860d3ec365..67a2f60440ca 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param) reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE); poke32(VGA_CONFIGURATION, reg); } else { -#if defined(__i386__) || defined(__x86_64__) +#ifdef CONFIG_X86 /* set graphic mode via IO method */ outb_p(0x88, 0x3d4); outb_p(0x06, 0x3d5);
Replace architecture-specific defines with CONFIG_X86 checks to improve portability and adhere to kernel coding standards. Fixes checkpatch warning: - CHECK: architecture specific defines should be avoided. Changes made: - Using CONFIG_X86 instead of i386 and x86. Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)