| Message ID | b10c4df7c5ac10d9290c3b9d2f113fb2f337b110.1502179820.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote: > Enable this driver for Xilinx ZynqMP. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Not a comment on the patch per se, but I would advice you to look into migrating the Xilinx frame buffer to DRI/DRM/KMS. The recent CMA helpers has made it very simple and focused to write DRM drivers. See for example drivers/gpu/drm/pl111 Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14.8.2017 15:42, Linus Walleij wrote: > On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote: > >> Enable this driver for Xilinx ZynqMP. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > Not a comment on the patch per se, but I would advice you to look into > migrating the Xilinx frame buffer to DRI/DRM/KMS. > > The recent CMA helpers has made it very simple and focused to write > DRM drivers. See for example drivers/gpu/drm/pl111 There is a lot of work done by xilinx in this area gpu/drm/kms. I am trying to upstream what xilinx has in soc tree and this change is there. Maybe in this case it is useless and none is using it but it is there and I don't want to break user. There shouldn't be any technical problem to run this old fb driver in pl on arm64. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek <michal.simek@xilinx.com> wrote: > On 14.8.2017 15:42, Linus Walleij wrote: >> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote: >> >>> Enable this driver for Xilinx ZynqMP. >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> >> Not a comment on the patch per se, but I would advice you to look into >> migrating the Xilinx frame buffer to DRI/DRM/KMS. >> >> The recent CMA helpers has made it very simple and focused to write >> DRM drivers. See for example drivers/gpu/drm/pl111 > > There is a lot of work done by xilinx in this area gpu/drm/kms. I am > trying to upstream what xilinx has in soc tree and this change is there. > Maybe in this case it is useless and none is using it but it is there > and I don't want to break user. There shouldn't be any technical problem > to run this old fb driver in pl on arm64. A proper drm kms driver gives you backwards compat for fbdev for free. And we're taking in patches to fill feature gaps in our fbdev emulation as people hit them. There no reason nowadays at all to merge new fbdev native drivers, your users will be taken care of by a drm kms driver fully. -Daniel
On 14.8.2017 15:49, Daniel Vetter wrote: > On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek <michal.simek@xilinx.com> wrote: >> On 14.8.2017 15:42, Linus Walleij wrote: >>> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote: >>> >>>> Enable this driver for Xilinx ZynqMP. >>>> >>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> >>> Not a comment on the patch per se, but I would advice you to look into >>> migrating the Xilinx frame buffer to DRI/DRM/KMS. >>> >>> The recent CMA helpers has made it very simple and focused to write >>> DRM drivers. See for example drivers/gpu/drm/pl111 >> >> There is a lot of work done by xilinx in this area gpu/drm/kms. I am >> trying to upstream what xilinx has in soc tree and this change is there. >> Maybe in this case it is useless and none is using it but it is there >> and I don't want to break user. There shouldn't be any technical problem >> to run this old fb driver in pl on arm64. > > A proper drm kms driver gives you backwards compat for fbdev for free. > And we're taking in patches to fill feature gaps in our fbdev > emulation as people hit them. There no reason nowadays at all to merge > new fbdev native drivers, your users will be taken care of by a drm > kms driver fully. You can look at xilinx work in this area. https://github.com/Xilinx/linux-xlnx Unfortunately they haven't started to upstream it. In this particular case I am not aware about anybody who is going to write new driver for this soft IP. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, August 08, 2017 10:10:26 AM Michal Simek wrote: > Enable this driver for Xilinx ZynqMP. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 5c6696bb56da..5e58f5ec0a28 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2173,7 +2173,7 @@ config FB_PS3_DEFAULT_SIZE_M config FB_XILINX tristate "Xilinx frame buffer support" - depends on FB && (XILINX_VIRTEX || MICROBLAZE || ARCH_ZYNQ) + depends on FB && (XILINX_VIRTEX || MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP) select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT
Enable this driver for Xilinx ZynqMP. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)