| Message ID | bbdf9102afd4b72160d274a575a2f1eea5580afb.1475387062.git.mgmoshes@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > Rename CamelCased macro roundedDiv to rounded_div. > > This issue was found by checkpatch.pl > > Signed-off-by: Moshe Green <mgmoshes@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 3a0afe1..e4efe91 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -7,7 +7,7 @@ > #include "ddk750_power.h" > > /* n / d + 1 / 2 = (2n + d) / 2d */ > -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) > +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) Shouldn't you use the in-kernel function for this instead? -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Oct 02, 2016 at 11:47:47AM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > > Rename CamelCased macro roundedDiv to rounded_div. > > > > This issue was found by checkpatch.pl > > > > Signed-off-by: Moshe Green <mgmoshes@gmail.com> > > --- > > drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > > index 3a0afe1..e4efe91 100644 > > --- a/drivers/staging/sm750fb/ddk750_chip.c > > +++ b/drivers/staging/sm750fb/ddk750_chip.c > > @@ -7,7 +7,7 @@ > > #include "ddk750_power.h" > > > > /* n / d + 1 / 2 = (2n + d) / 2d */ > > -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) > > +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) > > Shouldn't you use the in-kernel function for this instead? (I thought briefly of looking for an existing implementation but then chose not to since I wanted to minimize the functional changes in my patches for the time being. Additionally I was wary of using a different implementation for a division operation.) I'll submit a patch that will replace the local implemetaion of rounded division with the in-kernel implementation (I'm assuming you're referring to the DIV_ROUND_CLOSEST macro from include/linux/kernel.h). Thanks Moshe Green -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 3a0afe1..e4efe91 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -7,7 +7,7 @@ #include "ddk750_power.h" /* n / d + 1 / 2 = (2n + d) / 2d */ -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) #define MHz(x) ((x) * 1000000) logical_chip_type_t sm750_get_chip_type(void) @@ -102,7 +102,7 @@ static void setMemoryClock(unsigned int frequency) frequency = MHz(336); /* Calculate the divisor */ - divisor = roundedDiv(get_mxclk_freq(), frequency); + divisor = rounded_div(get_mxclk_freq(), frequency); /* Set the corresponding divisor in the register. */ reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_M2XCLK_MASK; @@ -152,7 +152,7 @@ static void setMasterClock(unsigned int frequency) frequency = MHz(190); /* Calculate the divisor */ - divisor = roundedDiv(get_mxclk_freq(), frequency); + divisor = rounded_div(get_mxclk_freq(), frequency); /* Set the corresponding divisor in the register. */ reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_MCLK_MASK;
Rename CamelCased macro roundedDiv to rounded_div. This issue was found by checkpatch.pl Signed-off-by: Moshe Green <mgmoshes@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)