From patchwork Wed Feb 21 11:49:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 10232017 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B49B160209 for ; Wed, 21 Feb 2018 11:49:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7D12289AE for ; Wed, 21 Feb 2018 11:49:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B1A728B02; Wed, 21 Feb 2018 11:49:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A728289AE for ; Wed, 21 Feb 2018 11:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048AbeBULtn (ORCPT ); Wed, 21 Feb 2018 06:49:43 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48968 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391AbeBULtn (ORCPT ); Wed, 21 Feb 2018 06:49:43 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1LBexa4038469 for ; Wed, 21 Feb 2018 06:49:42 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g95y55mkp-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 21 Feb 2018 06:49:42 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Feb 2018 11:49:39 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 21 Feb 2018 11:49:37 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1LBnaXb48496846; Wed, 21 Feb 2018 11:49:36 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8052C11C050; Wed, 21 Feb 2018 11:42:39 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C95E11C04C; Wed, 21 Feb 2018 11:42:39 +0000 (GMT) Received: from oc7330422307.ibm.com (unknown [9.152.96.255]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 21 Feb 2018 11:42:39 +0000 (GMT) Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support To: Thomas Huth , Cornelia Huck Cc: Farhan Ali , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org, geert@linux-m68k.org, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com References: <2beec7645bac82e7bdef4f6df0b9f4fe28696575.1519053920.git.alifm@linux.vnet.ibm.com> <6cae85dc-76d5-1b92-ab13-a5e441eb84a0@linux.vnet.ibm.com> <20180221113217.11bb1c69.cohuck@redhat.com> <1f8907d4-c4a3-d41b-8834-679dcc85de4a@de.ibm.com> <5dfa9213-0e63-54d0-8700-1ced4efd4c28@redhat.com> From: Christian Borntraeger Date: Wed, 21 Feb 2018 12:49:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <5dfa9213-0e63-54d0-8700-1ced4efd4c28@redhat.com> Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18022111-0040-0000-0000-00000414FC8B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18022111-0041-0000-0000-000026180DA0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-21_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802210145 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 02/21/2018 12:29 PM, Thomas Huth wrote: > On 21.02.2018 12:22, Christian Borntraeger wrote: >> >> >> On 02/21/2018 12:14 PM, Thomas Huth wrote: >>> On 21.02.2018 12:09, Christian Borntraeger wrote: >>>> >>>> >>>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: >>>>> On Wed, 21 Feb 2018 11:22:38 +0100 >>>>> Christian Borntraeger wrote: >>>>> >>>>>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: >>>>>>> >>>>>>> >>>>>>> On 02/19/2018 05:38 PM, Farhan Ali wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote: >>>>>>>>> On 19.02.2018 16:47, Farhan Ali wrote: >>>>>>>>>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' >>>>>>>>>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >>>>>>>>>> "Graphics support" menu for S390. But if we enable VT layer for S390, >>>>>>>>>> we would also need to enable the dummy console. So let's remove the >>>>>>>>>> HAS_IOMEM dependency. >>>>>>>>>> >>>>>>>>>> Move this dependency to sub menu items and console drivers that use >>>>>>>>>> io memory. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Farhan Ali >>>>>>>>>> --- >>>>>>>>>>   drivers/video/Kconfig         | 21 +++++++++++---------- >>>>>>>>>>   drivers/video/console/Kconfig |  4 ++-- >>>>>>>>>>   2 files changed, 13 insertions(+), 12 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>>>>>>>>> index 3c20af9..8f10915 100644 >>>>>>>>>> --- a/drivers/video/Kconfig >>>>>>>>>> +++ b/drivers/video/Kconfig >>>>>>>>>> @@ -3,7 +3,6 @@ >>>>>>>>>>   # >>>>>>>>>>     menu "Graphics support" >>>>>>>>>> -    depends on HAS_IOMEM >>>>>>>>>>     config HAVE_FB_ATMEL >>>>>>>>>>       bool >>>>>>>>>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >>>>>>>>>>   config SH_LCD_MIPI_DSI >>>>>>>>>>       bool >>>>>>>>>>   -source "drivers/char/agp/Kconfig" >>>>>>>>>> +if HAS_IOMEM >>>>>>>>>> +    source "drivers/char/agp/Kconfig" >>>>>>>>>>   -source "drivers/gpu/vga/Kconfig" >>>>>>>>>> +    source "drivers/gpu/vga/Kconfig" >>>>>>>>>>   -source "drivers/gpu/host1x/Kconfig" >>>>>>>>>> -source "drivers/gpu/ipu-v3/Kconfig" >>>>>>>>>> +    source "drivers/gpu/host1x/Kconfig" >>>>>>>>>> +    source "drivers/gpu/ipu-v3/Kconfig" >>>>>>>>>>   -source "drivers/gpu/drm/Kconfig" >>>>>>>>>> +    source "drivers/gpu/drm/Kconfig" >>>>>>> >>>>>>> >>>>>>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more >>>>>>> work. >>>>>>> >>>>>> Sorry my fault. I had CONFIG_PCI disabled. >>>>> >>>>> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess >>>>> that you want to enable a ccw virtio-gpu device, not a pci one, right? >>>> >>>> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot >>>> select VIRTIO_GPU, which needs DRM, which need IOMEM. >>> >>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside >>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? >> >> virtio-gpu depends on drm. So in essence it boils down to if you want virtio-gpu >> you also need to enable PCI, even if the actual channel is ccw. > > But if you need to enable PCI to get IOMEM, I wonder why this patch here > is needed at all? The Graphics menu / VT dummy console should be > available in the config if IOMEM is enabled anyway? That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. IIRC the issue was that with patch 3 we can have the situation where we have CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as conswitchp is NULL. This patches goal was to always enable dummy console even without PCI, but it obviously fails to do so. So what about allowing CONFIG_VT on s390 only if we have PCI? --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig index 84810075a6a0..1c7fe09d6f90 100644 --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -11,7 +11,7 @@ if TTY config VT bool "Virtual terminal" if EXPERT - depends on !UML + depends on !UML && (!S390 || PCI) select INPUT default y ---help---