From patchwork Wed Oct 7 00:09:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russ Weight X-Patchwork-Id: 11819411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE3DE175A for ; Wed, 7 Oct 2020 00:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94A9E20739 for ; Wed, 7 Oct 2020 00:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbgJGAKa (ORCPT ); Tue, 6 Oct 2020 20:10:30 -0400 Received: from mga04.intel.com ([192.55.52.120]:3648 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgJGAK3 (ORCPT ); Tue, 6 Oct 2020 20:10:29 -0400 IronPort-SDR: p504MBfVycZpm4gBB7UJHgEOWr8Nf0Ma47Rsx57lM0yR2Y8saP+sIUC6xBe8Ec7TJabglHTk80 R8mDgp8GVmaw== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="162139521" X-IronPort-AV: E=Sophos;i="5.77,344,1596524400"; d="scan'208";a="162139521" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 17:10:28 -0700 IronPort-SDR: XXr+acD89v7hMEKrHEO0qFM/ze51Fv0HpXRQGYyfOBC7QtJXSfBAdXzK1fz2GtGsXnSMjZuPGS 8ZUCwBxU61dQ== X-IronPort-AV: E=Sophos;i="5.77,344,1596524400"; d="scan'208";a="297380398" Received: from rhweight-mobl2.amr.corp.intel.com (HELO rhweight-mobl2.ra.intel.com) ([10.212.2.223]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 17:10:27 -0700 From: Russ Weight To: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com, Russ Weight Subject: [PATCH v3 0/7] Intel FPGA Security Manager Class Driver Date: Tue, 6 Oct 2020 17:09:57 -0700 Message-Id: <20201007001004.23790-1-russell.h.weight@intel.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org The Intel FPGA Security Manager class driver provides a common API for user-space tools to manage updates for secure Intel FPGA devices. Device drivers that instantiate the Intel Security Manager class driver will interact with a HW secure update engine in order to transfer new FPGA and BMC images to FLASH so that they will be automatically loaded when the FPGA card reboots. A significant difference between the FPGA Manager and the Intel FPGA Security Manager is that the FPGA Manager does a live update (Partial Reconfiguration) to a device whereas the Intel FPGA Security Manager updates the FLASH images for the Static Region and the BMC so that they will be loaded the next time the FPGA card boots. Security is enforced by hardware and firmware. The security manager interacts with the firmware to initiate an update, pass in the necessary data, and collect status on the update. The n3000bmc-secure driver is the first driver to use the Intel FPG Security Manager. This driver was previously submitted in the same patch set, but has been split out in to a separate patch set starting with V2. Follow-on Intel devices will also make use of this common API for secure updates. In addition to managing secure updates of the FPGA and BMC images, the Intel FPGA Security Manager update process may also be used to program root entry hashes and cancellation keys for the FPGA static region, the FPGA partial reconfiguration region, and the BMC. Secure updates make use of the request_firmware framework, which requires that image files are accessible under /lib/firmware. A request for a secure update returns immediately, while the update itself proceeds in the context of a kernel worker thread. Sysfs files provide a means for monitoring the progress of a secure update and for retrieving error information in the event of a failure. The API consists of sysfs nodes and supports the following functions: (1) Instantiate and monitor a secure update (2) Display security information including: Root Entry Hashes (REH), Cancelled Code Signing Keys (CSK), and flash update counts for both BMC and FPGA images. Changelog v2 -> v3: - Use dev_err() to report invalid progress in sec_progress() - Use dev_err() to report invalid error code in sec_error() - Modified sysfs handler check in check_sysfs_handler() to make it more readable. - Removed unnecessary "goto done" - Added a comment to explain imgr->driver_unload in ifpga_sec_mgr_unregister() Changelog v1 -> v2: - Separated out the MAX10 BMC Security Engine to be submitted in a separate patch-set. - Bumped documentation dates and versions - Split ifpga_sec_mgr_register() into create() and register() functions - Added devm_ifpga_sec_mgr_create() - Added Documentation/fpga/ifpga-sec-mgr.rst - Changed progress state "read_file" to "reading" - Added sec_error() function (similar to sec_progress()) - Removed references to bmc_flash_count & smbus_flash_count (not supported) - Removed typedefs for imgr ops - Removed explicit value assignments in enums - Other minor code cleanup per review comments Russ Weight (7): fpga: sec-mgr: intel fpga security manager class driver fpga: sec-mgr: enable secure updates fpga: sec-mgr: expose sec-mgr update status fpga: sec-mgr: expose sec-mgr update errors fpga: sec-mgr: expose sec-mgr update size fpga: sec-mgr: enable cancel of secure update fpga: sec-mgr: expose hardware error info .../ABI/testing/sysfs-class-ifpga-sec-mgr | 143 ++++ Documentation/fpga/ifpga-sec-mgr.rst | 50 ++ Documentation/fpga/index.rst | 1 + MAINTAINERS | 9 + drivers/fpga/Kconfig | 9 + drivers/fpga/Makefile | 3 + drivers/fpga/ifpga-sec-mgr.c | 786 ++++++++++++++++++ include/linux/fpga/ifpga-sec-mgr.h | 137 +++ 8 files changed, 1138 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-ifpga-sec-mgr create mode 100644 Documentation/fpga/ifpga-sec-mgr.rst create mode 100644 drivers/fpga/ifpga-sec-mgr.c create mode 100644 include/linux/fpga/ifpga-sec-mgr.h