From patchwork Sat Oct 13 04:53:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 10639927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C6ECF112B for ; Sat, 13 Oct 2018 04:56:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5A6A2B524 for ; Sat, 13 Oct 2018 04:56:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9BBA2B541; Sat, 13 Oct 2018 04:56:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C4212B524 for ; Sat, 13 Oct 2018 04:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbeJMMav (ORCPT ); Sat, 13 Oct 2018 08:30:51 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46089 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbeJMMau (ORCPT ); Sat, 13 Oct 2018 08:30:50 -0400 Received: by mail-pf1-f193.google.com with SMTP id r64-v6so7147172pfb.13; Fri, 12 Oct 2018 21:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CCjwtqQtCAOwIXfabE6A59py+g67jCSp+upDI4OtmXg=; b=XjLKBF08ZQ+dsEyY+1vcvgFDvIQUH+3J+mij+q0zb8rlPtPBVFuf5qpY1NOYkLMfWI LqJaauyLUA2EQ/lBipHWNE0gvwzV7tNahnPnfKggwln8idyWVA6EVc1MNMpOXBMduylD hbUgnmPJ3tMlT7Ez7ftzWY9/qtX+3Z8PEP+Wx6XfJEnvDQwMYWSHtLZezIJITXjbsgzr qxFUauNaVKokdPIeKVZxfVgmERQM91b3Al/4t14pd+5anf9hSVdzeG0KAt7gK3Br4dze MFzqaiAyDAcx9IFrwN8uYqjthUhxIim9HYDqu2myBuMCvzZsF6TY1FJsuVS7IATvdWvM KT4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CCjwtqQtCAOwIXfabE6A59py+g67jCSp+upDI4OtmXg=; b=MtP/UR9hxmoFEcK0z7zqLGJZ4HwaKeDK+4gcT34BefKAC3TLoJa4+Y6u4PG9poyPUH TzJDtptIkintvprrtRFZch61eQz2b+0FD7Z68T0ndRdNDa6JdzZzxznlM462c7maLzZx B4xpJAoXyW5CCgGkBPFdzIO5HBXS895eFNzDEr9wR4poamNT4f3LlTHRJShL+8UQB006 hQce+HB/Cqw5NZGnmNyKJWWzbl8looNsodVa7otBh7EKNUF8iSt3ys3J87D5ajknz+kW BxMQ3cFONciQ3eLh1kRnbZDyi+VAs8VpyiI+0KcwcxtTFIZ4OcTEKpX5GvMqWimbSM77 T4YQ== X-Gm-Message-State: ABuFfogcVKTIzwXjNSB988y+f8dY9+tsP9dWspBv7Z2uElFHHtOvnfhs G7YUyYaEgF9wQ1vR3HdRiFQ= X-Google-Smtp-Source: ACcGV63Jw8JZON7Ti8uWdCVxtgPjcr/J6vei2RiqRNuBSRDqGBHpxXgxxuMvJCv9Z1oTfYAqhkmFJQ== X-Received: by 2002:a63:565d:: with SMTP id g29-v6mr7995901pgm.227.1539406509460; Fri, 12 Oct 2018 21:55:09 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id h87-v6sm6959462pfj.78.2018.10.12.21.55.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Oct 2018 21:55:08 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v2 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node() Date: Fri, 12 Oct 2018 21:53:24 -0700 Message-Id: <1539406418-18162-5-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539406418-18162-1-git-send-email-frowand.list@gmail.com> References: <1539406418-18162-1-git-send-email-frowand.list@gmail.com> Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Frank Rowand "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" added a missing of_node_get() to __of_attach_node_sysfs(). This results in a refcount imbalance for nodes attached with dlpar_attach_node(). The calling sequence from dlpar_attach_node() to __of_attach_node_sysfs() is: dlpar_attach_node() of_attach_node() __of_attach_node_sysfs() Signed-off-by: Frank Rowand --- ***** UNTESTED. I need people with the affected PowerPC systems ***** (systems that dynamically allocate and deallocate ***** devicetree nodes) to test this patch. arch/powerpc/platforms/pseries/dlpar.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index a0b20c03f078..e3010b14aea5 100644 --- a/arch/powerpc/platforms/pseries/dlpar.c +++ b/arch/powerpc/platforms/pseries/dlpar.c @@ -272,6 +272,8 @@ int dlpar_detach_node(struct device_node *dn) if (rc) return rc; + of_node_put(dn); + return 0; }