diff mbox

fpga: Convert to using %pOF instead of full_name

Message ID 20170718214339.7774-22-robh@kernel.org
State Accepted
Headers show

Commit Message

Rob Herring July 18, 2017, 9:43 p.m. UTC
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: linux-fpga@vger.kernel.org
---
 drivers/fpga/fpga-region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Moritz Fischer July 19, 2017, 4:42 a.m. UTC | #1
On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: linux-fpga@vger.kernel.org
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
>  drivers/fpga/fpga-region.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index 3b6b2f4182a1..d9ab7c75b14f 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>  	of_node_put(child_region);
> 
>  	if (ret)
> -		pr_err("firmware-name not allowed in child FPGA region: %s",
> -		       child_region->full_name);
> +		pr_err("firmware-name not allowed in child FPGA region: %pOF",
> +		       child_region);
> 
>  	return ret;
>  }
> --
> 2.11.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull July 19, 2017, 2:32 p.m. UTC | #2
On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
> Acked-by: Moritz Fischer <mdf@kernel.org>

Acked-by: Alan Tull <atull@kernel.org>

>> ---
>>  drivers/fpga/fpga-region.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
>> index 3b6b2f4182a1..d9ab7c75b14f 100644
>> --- a/drivers/fpga/fpga-region.c
>> +++ b/drivers/fpga/fpga-region.c
>> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>>       of_node_put(child_region);
>>
>>       if (ret)
>> -             pr_err("firmware-name not allowed in child FPGA region: %s",
>> -                    child_region->full_name);
>> +             pr_err("firmware-name not allowed in child FPGA region: %pOF",
>> +                    child_region);
>>
>>       return ret;
>>  }
>> --
>> 2.11.0
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Aug. 9, 2017, 9:54 p.m. UTC | #3
On Wed, Jul 19, 2017 at 9:32 AM, Alan Tull <atull@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@kernel.org> wrote:
>> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>>> Now that we have a custom printf format specifier, convert users of
>>> full_name to use %pOF instead. This is preparation to remove storing
>>> of the full path string for each node.
>>>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> Cc: Alan Tull <atull@kernel.org>
>>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>>> Cc: linux-fpga@vger.kernel.org
>> Acked-by: Moritz Fischer <mdf@kernel.org>
>
> Acked-by: Alan Tull <atull@kernel.org>

This hasn't been applied in -next. Are you going to send to Greg?

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull Aug. 10, 2017, 2:16 p.m. UTC | #4
I sent it on 8/2/2017.  I probably missed a window.

Alan

On Wed, Aug 9, 2017 at 4:54 PM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jul 19, 2017 at 9:32 AM, Alan Tull <atull@kernel.org> wrote:
>> On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@kernel.org> wrote:
>>> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>>>> Now that we have a custom printf format specifier, convert users of
>>>> full_name to use %pOF instead. This is preparation to remove storing
>>>> of the full path string for each node.
>>>>
>>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>>> Cc: Alan Tull <atull@kernel.org>
>>>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>>>> Cc: linux-fpga@vger.kernel.org
>>> Acked-by: Moritz Fischer <mdf@kernel.org>
>>
>> Acked-by: Alan Tull <atull@kernel.org>
>
> This hasn't been applied in -next. Are you going to send to Greg?
>
> Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index 3b6b2f4182a1..d9ab7c75b14f 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -319,8 +319,8 @@  static int child_regions_with_firmware(struct device_node *overlay)
 	of_node_put(child_region);

 	if (ret)
-		pr_err("firmware-name not allowed in child FPGA region: %s",
-		       child_region->full_name);
+		pr_err("firmware-name not allowed in child FPGA region: %pOF",
+		       child_region);

 	return ret;
 }