From patchwork Thu Mar 29 15:36:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moritz Fischer X-Patchwork-Id: 10315617 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AA9D660383 for ; Thu, 29 Mar 2018 15:44:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9D8E27DA4 for ; Thu, 29 Mar 2018 15:44:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C9A1286B3; Thu, 29 Mar 2018 15:44:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 13EB928632 for ; Thu, 29 Mar 2018 15:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbeC2Pm6 (ORCPT ); Thu, 29 Mar 2018 11:42:58 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36637 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334AbeC2Pm5 (ORCPT ); Thu, 29 Mar 2018 11:42:57 -0400 Received: by mail-pf0-f193.google.com with SMTP id g14so3493272pfh.3 for ; Thu, 29 Mar 2018 08:42:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s+GCWH9CEUM3Iss03E8MPXZzcEz/46i41NLRVCS+HlU=; b=oW3gyP6MGcbheKUFn4uk+QnxxPuIQtm3BsgrjzAFS3Dthet6B2xuNTQNNFxrM5dbFo +pqE4QSCT6z3BdxGFVwQjczBNWkmoB2jVb8/0mZRQgZlkYhGCZ87t2tonr4uW9m5L58S aY8x3IK2oK2sdNCwVWVflKWJhE1MFVe/D1RlrtzAqGijad2av1OvXO3S9g8UAXr40S2e q/cjUocPddzIT3rgpeiTmd7JyoRm/zwULirVsaYsOHrUkNdRHZxfuz/goWTj9LnbXCkf u9hp/o05Vs9jPenHzdSqxA4wQvrMpld7nwWnEhh9TdJCzgLdy3+Mqo6qzWTWYlGyAcTe JG7g== X-Gm-Message-State: AElRT7GisFdGiojqOYKDiooyf8vn7hYEua/plnT8KkMKezMVGepdNieY rpHVdcuMn0dxM/TI1VRXGewFiA== X-Google-Smtp-Source: AIpwx49GvhiccuYJQxSvsqhEFcW57igajE8EswBHfbsOPeeMWcerHrxRawps06iWj3QusiDAhKU3Bw== X-Received: by 2002:a17:902:ab88:: with SMTP id f8-v6mr2974463plr.34.1522338176613; Thu, 29 Mar 2018 08:42:56 -0700 (PDT) Received: from localhost ([207.114.172.147]) by smtp.gmail.com with ESMTPSA id f22sm15541770pff.146.2018.03.29.08.42.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Mar 2018 08:42:55 -0700 (PDT) From: Moritz Fischer To: gregkh@linuxfoundation.org Cc: atull@kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, Moritz Fischer Subject: [PATCH 1/6] fpga: region: don't use drvdata in common fpga code Date: Thu, 29 Mar 2018 08:36:53 -0700 Message-Id: <20180329153658.11614-2-mdf@kernel.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180329153658.11614-1-mdf@kernel.org> References: <20180329153658.11614-1-mdf@kernel.org> Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Alan Tull Part of patchset that changes the following fpga_*_register functions to not set drvdata: * fpga_region_register. * fpga_mgr_register * fpga_bridge_register The rationale is that setting drvdata is fine for DT based devices that will have one manager, bridge, or region per platform device. However PCIe based devices may have multiple FPGA mgr/bridge/regions under one PCIe device. Without these changes, the PCIe solution has to create an extra device for each child mgr/bridge/region to hold drvdata. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-region.c | 1 - drivers/fpga/of-fpga-region.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index edab2a2e03ef..ebe1f872810d 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -178,7 +178,6 @@ int fpga_region_register(struct device *dev, struct fpga_region *region) region->dev.parent = dev; region->dev.of_node = dev->of_node; region->dev.id = id; - dev_set_drvdata(dev, region); ret = dev_set_name(®ion->dev, "region%d", id); if (ret) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 119ff75522f1..35e7e8c4a0cb 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -438,6 +438,7 @@ static int of_fpga_region_probe(struct platform_device *pdev) goto eprobe_mgr_put; of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); + dev_set_drvdata(dev, region); dev_info(dev, "FPGA Region probed\n");