diff mbox series

[RESEND,v10,5/7] fpga: sec-mgr: expose sec-mgr update size

Message ID 20210322155028.531323-6-russell.h.weight@intel.com (mailing list archive)
State New
Headers show
Series FPGA Security Manager Class Driver | expand

Commit Message

Russ Weight March 22, 2021, 3:50 p.m. UTC
Extend the FPGA Security Manager class driver to include
an update/remaining_size sysfs node that can be read to
determine how much data remains to be transferred to the
secure update engine. This file can be used to monitor
progress during the "writing" phase of an update.

Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
  - Rebased to 5.12-rc2 next
  - Updated Date and KernelVersion in ABI documentation
  - Updated Date and KernelVersion in ABI documentation
  - No change
  - Changed Date in documentation file to December 2020
  - No change
  - Use new function sysfs_emit() in the remaining_size_show() function
  - Changed from "Intel FPGA Security Manager" to FPGA Security Manager"
    and removed unnecessary references to "Intel".
  - Changed: imgr -> smgr, ifpga_ to fpga_
  - No change
  - Bumped documentation date and version
 Documentation/ABI/testing/sysfs-class-fpga-sec-mgr | 11 +++++++++++
 drivers/fpga/fpga-sec-mgr.c                        | 10 ++++++++++
 2 files changed, 21 insertions(+)
diff mbox series


diff --git a/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr b/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
index 77738577b2c3..2e1f60edf546 100644
--- a/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
+++ b/Documentation/ABI/testing/sysfs-class-fpga-sec-mgr
@@ -28,6 +28,17 @@  Description:	Read-only. Returns a string describing the current
 		as it will be signaled by sysfs_notify() on each
 		state change.
+What: 		/sys/class/fpga_sec_mgr/fpga_secX/update/remaining_size
+Date:		April 2021
+KernelVersion:  5.13
+Contact:	Russ Weight <russell.h.weight@intel.com>
+Description:	Read-only. Returns the size of data that remains to
+		be written to the secure update engine. The size
+		value is initialized to the full size of the file
+		image and the value is updated periodically during
+		the "writing" phase of the update.
+		Format: "%u".
 What: 		/sys/class/fpga_sec_mgr/fpga_secX/update/error
 Date:		April 2021
 KernelVersion:  5.13
diff --git a/drivers/fpga/fpga-sec-mgr.c b/drivers/fpga/fpga-sec-mgr.c
index 3bd89598cccd..951020942991 100644
--- a/drivers/fpga/fpga-sec-mgr.c
+++ b/drivers/fpga/fpga-sec-mgr.c
@@ -204,6 +204,15 @@  error_show(struct device *dev, struct device_attribute *attr, char *buf)
 static DEVICE_ATTR_RO(error);
+static ssize_t remaining_size_show(struct device *dev,
+				   struct device_attribute *attr, char *buf)
+	struct fpga_sec_mgr *smgr = to_sec_mgr(dev);
+	return sysfs_emit(buf, "%u\n", smgr->remaining_size);
+static DEVICE_ATTR_RO(remaining_size);
 static ssize_t filename_store(struct device *dev, struct device_attribute *attr,
 			      const char *buf, size_t count)
@@ -240,6 +249,7 @@  static struct attribute *sec_mgr_update_attrs[] = {
+	&dev_attr_remaining_size.attr,