diff mbox series

[6/7] fpga: xilinx: remove xilinx- prefix on files

Message ID 20210608162551.3010533-1-trix@redhat.com (mailing list archive)
State Rejected
Headers show
Series fpga: reorganize to subdirs | expand

Commit Message

Tom Rix June 8, 2021, 4:25 p.m. UTC
From: Tom Rix <trix@redhat.com>

It is not necessary to have a xilinx- prefix on a file
when the file is in a xilinx/ subdir.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/fpga/xilinx/Makefile                                  | 4 ++--
 drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
 drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
 rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)

Comments

Greg KH June 9, 2021, 9:59 a.m. UTC | #1
On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> It is not necessary to have a xilinx- prefix on a file
> when the file is in a xilinx/ subdir.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/fpga/xilinx/Makefile                                  | 4 ++--
>  drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
>  drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
>  rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
> 
> diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
> index 7bb7543412790..4ac727d03e140 100644
> --- a/drivers/fpga/xilinx/Makefile
> +++ b/drivers/fpga/xilinx/Makefile
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
> -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
> +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
> +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o

You just renamed the module to be called "spi.ko"????

Did you test this thing?  You can not rename modules without good
reasons, and calling a device specific kernel module "spi.ko" is not ok.

greg k-h
Tom Rix June 9, 2021, 1:27 p.m. UTC | #2
On 6/9/21 2:59 AM, Greg KH wrote:
> On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> It is not necessary to have a xilinx- prefix on a file
>> when the file is in a xilinx/ subdir.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   drivers/fpga/xilinx/Makefile                                  | 4 ++--
>>   drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
>>   drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
>>   3 files changed, 2 insertions(+), 2 deletions(-)
>>   rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
>>   rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
>>
>> diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
>> index 7bb7543412790..4ac727d03e140 100644
>> --- a/drivers/fpga/xilinx/Makefile
>> +++ b/drivers/fpga/xilinx/Makefile
>> @@ -1,7 +1,7 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   
>> -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
>> -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
>> +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
>> +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
> You just renamed the module to be called "spi.ko"????
>
> Did you test this thing?  You can not rename modules without good
> reasons, and calling a device specific kernel module "spi.ko" is not ok.

yes, this is a problem, I will drop the renaming patches.

Tom

> greg k-h
>
Greg KH June 9, 2021, 2:57 p.m. UTC | #3
On Wed, Jun 09, 2021 at 06:27:05AM -0700, Tom Rix wrote:
> 
> On 6/9/21 2:59 AM, Greg KH wrote:
> > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > > 
> > > It is not necessary to have a xilinx- prefix on a file
> > > when the file is in a xilinx/ subdir.
> > > 
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > ---
> > >   drivers/fpga/xilinx/Makefile                                  | 4 ++--
> > >   drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
> > >   drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
> > >   3 files changed, 2 insertions(+), 2 deletions(-)
> > >   rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
> > >   rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
> > > 
> > > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
> > > index 7bb7543412790..4ac727d03e140 100644
> > > --- a/drivers/fpga/xilinx/Makefile
> > > +++ b/drivers/fpga/xilinx/Makefile
> > > @@ -1,7 +1,7 @@
> > >   # SPDX-License-Identifier: GPL-2.0
> > > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
> > > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
> > > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
> > > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
> > You just renamed the module to be called "spi.ko"????
> > 
> > Did you test this thing?  You can not rename modules without good
> > reasons, and calling a device specific kernel module "spi.ko" is not ok.
> 
> yes, this is a problem, I will drop the renaming patches.

So you didn't test these?

Again, why is this file movement necessary?
diff mbox series

Patch

diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
index 7bb7543412790..4ac727d03e140 100644
--- a/drivers/fpga/xilinx/Makefile
+++ b/drivers/fpga/xilinx/Makefile
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 
-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
-obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
+obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
 obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o
 obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
 
diff --git a/drivers/fpga/xilinx/xilinx-pr-decoupler.c b/drivers/fpga/xilinx/pr-decoupler.c
similarity index 100%
rename from drivers/fpga/xilinx/xilinx-pr-decoupler.c
rename to drivers/fpga/xilinx/pr-decoupler.c
diff --git a/drivers/fpga/xilinx/xilinx-spi.c b/drivers/fpga/xilinx/spi.c
similarity index 100%
rename from drivers/fpga/xilinx/xilinx-spi.c
rename to drivers/fpga/xilinx/spi.c