| Message ID | 20220308064315.1452217-1-tianfei.zhang@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] uio: dfl: add HSSI feature id | expand |
On 3/7/22 22:43, Tianfei Zhang wrote: > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > Add the feature id of the OFS High Speed Serial Interface > subsystem to table of ids supported by the uio_dfl driver. > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> Reviewed-by: Russ Weight <russell.h.weight@intel.com> > --- > drivers/uio/uio_dfl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c > index 89c0fc7b0cbc..660e1d0bf6b9 100644 > --- a/drivers/uio/uio_dfl.c > +++ b/drivers/uio/uio_dfl.c > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > } > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > static const struct dfl_device_id uio_dfl_ids[] = { > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, > { } > }; > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> On 3/7/22 22:43, Tianfei Zhang wrote: > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > Add the feature id of the OFS High Speed Serial Interface > > subsystem to table of ids supported by the uio_dfl driver. > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > --- > > drivers/uio/uio_dfl.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c > > index 89c0fc7b0cbc..660e1d0bf6b9 100644 > > --- a/drivers/uio/uio_dfl.c > > +++ b/drivers/uio/uio_dfl.c > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > > } > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 Where is the "OFS" coming from? is it for all OFS device or a specific card? Anyway, could we have a matched name per public table? https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst Hao > > > > static const struct dfl_device_id uio_dfl_ids[] = { > > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, > > { } > > }; > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> -----Original Message----- > From: Wu, Hao <hao.wu@intel.com> > Sent: Friday, March 11, 2022 10:47 AM > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > fpga@vger.kernel.org; gregkh@linuxfoundation.org > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > <matthew.gerlach@linux.intel.com> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > Add the feature id of the OFS High Speed Serial Interface subsystem > > > to table of ids supported by the uio_dfl driver. > > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > --- > > > drivers/uio/uio_dfl.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > --- a/drivers/uio/uio_dfl.c > > > +++ b/drivers/uio/uio_dfl.c > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > > > } > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > Where is the "OFS" coming from? is it for all OFS device or a specific card? > Anyway, could we have a matched name per public table? > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst Yes, I think a matched name of public table will be better. How about the " FME_FEATURE_ID_HSSI"? > > Hao > > > > > > > static const struct dfl_device_id uio_dfl_ids[] = { > > > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, > > > { } > > > }; > > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> > -----Original Message----- > > From: Wu, Hao <hao.wu@intel.com> > > Sent: Friday, March 11, 2022 10:47 AM > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei > > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > > fpga@vger.kernel.org; gregkh@linuxfoundation.org > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > <matthew.gerlach@linux.intel.com> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > Add the feature id of the OFS High Speed Serial Interface subsystem > > > > to table of ids supported by the uio_dfl driver. > > > > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > --- > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > --- a/drivers/uio/uio_dfl.c > > > > +++ b/drivers/uio/uio_dfl.c > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > > > > } > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > Where is the "OFS" coming from? is it for all OFS device or a specific card? > > Anyway, could we have a matched name per public table? > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst > > Yes, I think a matched name of public table will be better. How about the " > FME_FEATURE_ID_HSSI"? No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h #define FME_FEATURE_ID_HSSI 0x6 Need a new matched name. Hao > > > > > Hao > > > > > > > > > > static const struct dfl_device_id uio_dfl_ids[] = { > > > > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > > > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, > > > > { } > > > > }; > > > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> -----Original Message----- > From: Wu, Hao <hao.wu@intel.com> > Sent: Monday, March 14, 2022 11:09 AM > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > fpga@vger.kernel.org; gregkh@linuxfoundation.org > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > <matthew.gerlach@linux.intel.com> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > -----Original Message----- > > > From: Wu, Hao <hao.wu@intel.com> > > > Sent: Friday, March 11, 2022 10:47 AM > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei > > > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > > > fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > <matthew.gerlach@linux.intel.com> > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > > > Add the feature id of the OFS High Speed Serial Interface > > > > > subsystem to table of ids supported by the uio_dfl driver. > > > > > > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > > --- > > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > > --- a/drivers/uio/uio_dfl.c > > > > > +++ b/drivers/uio/uio_dfl.c > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device > > > > > *ddev) } > > > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > > > Where is the "OFS" coming from? is it for all OFS device or a specific card? > > > Anyway, could we have a matched name per public table? > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature > > > -ids.rst > > > > Yes, I think a matched name of public table will be better. How about the " > > FME_FEATURE_ID_HSSI"? > > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h > #define FME_FEATURE_ID_HSSI 0x6 Is it possible change the "FME_FEATURE_ID_HSSI" to " FME_FEATURE_ID_LEGACY_HSSI", and the new one is " FME_FEATURE_ID_HSSI"?
> > -----Original Message----- > > From: Wu, Hao <hao.wu@intel.com> > > Sent: Monday, March 14, 2022 11:09 AM > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > > fpga@vger.kernel.org; gregkh@linuxfoundation.org > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > <matthew.gerlach@linux.intel.com> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > -----Original Message----- > > > > From: Wu, Hao <hao.wu@intel.com> > > > > Sent: Friday, March 11, 2022 10:47 AM > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei > > > > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > > > > fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > <matthew.gerlach@linux.intel.com> > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > > > > > Add the feature id of the OFS High Speed Serial Interface > > > > > > subsystem to table of ids supported by the uio_dfl driver. > > > > > > > > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > > > --- > > > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > > > --- a/drivers/uio/uio_dfl.c > > > > > > +++ b/drivers/uio/uio_dfl.c > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device > > > > > > *ddev) } > > > > > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > > > > > Where is the "OFS" coming from? is it for all OFS device or a specific card? > > > > Anyway, could we have a matched name per public table? > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature > > > > -ids.rst > > > > > > Yes, I think a matched name of public table will be better. How about the " > > > FME_FEATURE_ID_HSSI"? > > > > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h > > #define FME_FEATURE_ID_HSSI 0x6 > > Is it possible change the "FME_FEATURE_ID_HSSI" to " > FME_FEATURE_ID_LEGACY_HSSI", and the new one is " > FME_FEATURE_ID_HSSI"? I am not sure who owns the ID allocation table, and why 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix for this HSSI instead, I hope we don't have to change this 0x15 HSSI to another legacy one when someone adds a new HSSI. This is for FPGA, everybody could implement his own HSSI, generic name should be avoid when possible, and a better rule when managing the feature IDs. >
> -----Original Message----- > From: Wu, Hao <hao.wu@intel.com> > Sent: Tuesday, March 15, 2022 5:32 PM > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > fpga@vger.kernel.org; gregkh@linuxfoundation.org > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > <matthew.gerlach@linux.intel.com> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > -----Original Message----- > > > From: Wu, Hao <hao.wu@intel.com> > > > Sent: Monday, March 14, 2022 11:09 AM > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > <matthew.gerlach@linux.intel.com> > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > -----Original Message----- > > > > > From: Wu, Hao <hao.wu@intel.com> > > > > > Sent: Friday, March 11, 2022 10:47 AM > > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, > > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com; > > > > > mdf@kernel.org; linux- fpga@vger.kernel.org; > > > > > gregkh@linuxfoundation.org > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > > <matthew.gerlach@linux.intel.com> > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > > > > > > > Add the feature id of the OFS High Speed Serial Interface > > > > > > > subsystem to table of ids supported by the uio_dfl driver. > > > > > > > > > > > > > > Signed-off-by: Matthew Gerlach > > > > > > > <matthew.gerlach@linux.intel.com> > > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > > > > --- > > > > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c > > > > > > > index > > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > > > > --- a/drivers/uio/uio_dfl.c > > > > > > > +++ b/drivers/uio/uio_dfl.c > > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct > > > > > > > dfl_device > > > > > > > *ddev) } > > > > > > > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > > > > > > > Where is the "OFS" coming from? is it for all OFS device or a specific > card? > > > > > Anyway, could we have a matched name per public table? > > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-fea > > > > > ture > > > > > -ids.rst > > > > > > > > Yes, I think a matched name of public table will be better. How about the " > > > > FME_FEATURE_ID_HSSI"? > > > > > > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h > > > #define FME_FEATURE_ID_HSSI 0x6 > > > > Is it possible change the "FME_FEATURE_ID_HSSI" to " > > FME_FEATURE_ID_LEGACY_HSSI", and the new one is " > > FME_FEATURE_ID_HSSI"? > > I am not sure who owns the ID allocation table, and why > 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix for > this HSSI instead, I hope we don't have to change this 0x15 HSSI to another > legacy one when someone adds a new HSSI. This is for FPGA, everybody could > implement his own HSSI, generic name should be avoid when possible, and a > better rule when managing the feature IDs. Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better. > > >
> > -----Original Message----- > > From: Wu, Hao <hao.wu@intel.com> > > Sent: Tuesday, March 15, 2022 5:32 PM > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > > fpga@vger.kernel.org; gregkh@linuxfoundation.org > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > <matthew.gerlach@linux.intel.com> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > -----Original Message----- > > > > From: Wu, Hao <hao.wu@intel.com> > > > > Sent: Monday, March 14, 2022 11:09 AM > > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; > > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > <matthew.gerlach@linux.intel.com> > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > > -----Original Message----- > > > > > > From: Wu, Hao <hao.wu@intel.com> > > > > > > Sent: Friday, March 11, 2022 10:47 AM > > > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, > > > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com; > > > > > > mdf@kernel.org; linux- fpga@vger.kernel.org; > > > > > > gregkh@linuxfoundation.org > > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > > > <matthew.gerlach@linux.intel.com> > > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > > > > > > > > > Add the feature id of the OFS High Speed Serial Interface > > > > > > > > subsystem to table of ids supported by the uio_dfl driver. > > > > > > > > > > > > > > > > Signed-off-by: Matthew Gerlach > > > > > > > > <matthew.gerlach@linux.intel.com> > > > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > > > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > > > > > --- > > > > > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c > > > > > > > > index > > > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > > > > > --- a/drivers/uio/uio_dfl.c > > > > > > > > +++ b/drivers/uio/uio_dfl.c > > > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct > > > > > > > > dfl_device > > > > > > > > *ddev) } > > > > > > > > > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > > > > > > > > > Where is the "OFS" coming from? is it for all OFS device or a specific > > card? > > > > > > Anyway, could we have a matched name per public table? > > > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-fea > > > > > > ture > > > > > > -ids.rst > > > > > > > > > > Yes, I think a matched name of public table will be better. How about the > " > > > > > FME_FEATURE_ID_HSSI"? > > > > > > > > No. We already have the same name for id 0x6 defined in > drivers/fpga/dfl.h > > > > #define FME_FEATURE_ID_HSSI 0x6 > > > > > > Is it possible change the "FME_FEATURE_ID_HSSI" to " > > > FME_FEATURE_ID_LEGACY_HSSI", and the new one is " > > > FME_FEATURE_ID_HSSI"? > > > > I am not sure who owns the ID allocation table, and why > > 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix > for > > this HSSI instead, I hope we don't have to change this 0x15 HSSI to another > > legacy one when someone adds a new HSSI. This is for FPGA, everybody could > > implement his own HSSI, generic name should be avoid when possible, and a > > better rule when managing the feature IDs. > > Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better. Then change the name in https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst as well. Hao > > > > > >
> -----Original Message----- > From: Wu, Hao <hao.wu@intel.com> > Sent: Thursday, March 17, 2022 8:42 AM > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux- > fpga@vger.kernel.org; gregkh@linuxfoundation.org > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > <matthew.gerlach@linux.intel.com> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > -----Original Message----- > > > From: Wu, Hao <hao.wu@intel.com> > > > Sent: Tuesday, March 15, 2022 5:32 PM > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > <matthew.gerlach@linux.intel.com> > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > -----Original Message----- > > > > > From: Wu, Hao <hao.wu@intel.com> > > > > > Sent: Monday, March 14, 2022 11:09 AM > > > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H > > > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; > > > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > > <matthew.gerlach@linux.intel.com> > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wu, Hao <hao.wu@intel.com> > > > > > > > Sent: Friday, March 11, 2022 10:47 AM > > > > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, > > > > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com; > > > > > > > mdf@kernel.org; linux- fpga@vger.kernel.org; > > > > > > > gregkh@linuxfoundation.org > > > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach > > > > > > > <matthew.gerlach@linux.intel.com> > > > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id > > > > > > > > > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote: > > > > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com> > > > > > > > > > > > > > > > > > > Add the feature id of the OFS High Speed Serial > > > > > > > > > Interface subsystem to table of ids supported by the uio_dfl > driver. > > > > > > > > > > > > > > > > > > Signed-off-by: Matthew Gerlach > > > > > > > > > <matthew.gerlach@linux.intel.com> > > > > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com> > > > > > > > > > > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > > > > > > > > --- > > > > > > > > > drivers/uio/uio_dfl.c | 2 ++ > > > > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > > > > > > > diff --git a/drivers/uio/uio_dfl.c > > > > > > > > > b/drivers/uio/uio_dfl.c index > > > > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644 > > > > > > > > > --- a/drivers/uio/uio_dfl.c > > > > > > > > > +++ b/drivers/uio/uio_dfl.c > > > > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct > > > > > > > > > dfl_device > > > > > > > > > *ddev) } > > > > > > > > > > > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > > > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15 > > > > > > > > > > > > > > Where is the "OFS" coming from? is it for all OFS device or > > > > > > > a specific > > > card? > > > > > > > Anyway, could we have a matched name per public table? > > > > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl > > > > > > > -fea > > > > > > > ture > > > > > > > -ids.rst > > > > > > > > > > > > Yes, I think a matched name of public table will be better. > > > > > > How about the > > " > > > > > > FME_FEATURE_ID_HSSI"? > > > > > > > > > > No. We already have the same name for id 0x6 defined in > > drivers/fpga/dfl.h > > > > > #define FME_FEATURE_ID_HSSI 0x6 > > > > > > > > Is it possible change the "FME_FEATURE_ID_HSSI" to " > > > > FME_FEATURE_ID_LEGACY_HSSI", and the new one is " > > > > FME_FEATURE_ID_HSSI"? > > > > > > I am not sure who owns the ID allocation table, and why > > > 0x6 is changed to "Legacy" HSSI but I feel it's better to have a > > > specific prefix > > for > > > this HSSI instead, I hope we don't have to change this 0x15 HSSI to > > > another legacy one when someone adds a new HSSI. This is for FPGA, > > > everybody could implement his own HSSI, generic name should be avoid > > > when possible, and a better rule when managing the feature IDs. > > > > Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better. > > Then change the name in > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst > as well. Thanks Hao's comment, it has changed to " OFS HSSI Subsystem" in this git repo.
diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index 89c0fc7b0cbc..660e1d0bf6b9 100644 --- a/drivers/uio/uio_dfl.c +++ b/drivers/uio/uio_dfl.c @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) } #define FME_FEATURE_ID_ETH_GROUP 0x10 +#define FME_FEATURE_ID_OFS_HSSI 0x15 static const struct dfl_device_id uio_dfl_ids[] = { { FME_ID, FME_FEATURE_ID_ETH_GROUP }, + { FME_ID, FME_FEATURE_ID_OFS_HSSI }, { } }; MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);