diff mbox series

[v3] uio: dfl: add HSSI subsystem feature id

Message ID 20220429005726.607804-1-tianfei.zhang@intel.com (mailing list archive)
State New
Headers show
Series [v3] uio: dfl: add HSSI subsystem feature id | expand

Commit Message

Tianfei Zhang April 29, 2022, 12:57 a.m. UTC
From: Matthew Gerlach <matthew.gerlach@linux.intel.com>

Add the Device Feature List (DFL) feature id for the
High Speed Serial Interface (HSSI) Subsystem to the
table of ids supported by the uio_dfl driver.

The HSSI Subsystem is a configurable set of IP blocks
to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
Like the Ethernet group used by the N3000 card, the HSSI
Subsystem does not fully implement a network device from
a Linux netdev perspective and is controlled and monitored
from user space software via the uio interface.

Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
---
v3: change the name of this feature id to HSSI_SUBSYS and rewrite
    the git message.
v2: add HSSI introduction and the git repo of Feature ID table.
---
 drivers/uio/uio_dfl.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rix April 29, 2022, 12:23 p.m. UTC | #1
On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Add the Device Feature List (DFL) feature id for the
> High Speed Serial Interface (HSSI) Subsystem to the
> table of ids supported by the uio_dfl driver.
>
> The HSSI Subsystem is a configurable set of IP blocks
> to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> Like the Ethernet group used by the N3000 card, the HSSI
> Subsystem does not fully implement a network device from
> a Linux netdev perspective and is controlled and monitored
> from user space software via the uio interface.

Generally you should include the url for the dfl definitions.

Can you add it here to the commit log ?

Otherwise fine.

Reviewed-by: Tom Rix <trix@redhat.com>

>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> v3: change the name of this feature id to HSSI_SUBSYS and rewrite
>      the git message.
> v2: add HSSI introduction and the git repo of Feature ID table.
> ---
>   drivers/uio/uio_dfl.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 89c0fc7b0cbc..8f39cc8bb034 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>   }
>   
>   #define FME_FEATURE_ID_ETH_GROUP	0x10
> +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
>   
>   static const struct dfl_device_id uio_dfl_ids[] = {
>   	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
Xu Yilun April 30, 2022, 2:24 p.m. UTC | #2
On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
> 
> On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > 
> > Add the Device Feature List (DFL) feature id for the
> > High Speed Serial Interface (HSSI) Subsystem to the
> > table of ids supported by the uio_dfl driver.
> > 
> > The HSSI Subsystem is a configurable set of IP blocks
> > to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> > Like the Ethernet group used by the N3000 card, the HSSI
> > Subsystem does not fully implement a network device from
> > a Linux netdev perspective and is controlled and monitored
> > from user space software via the uio interface.
> 
> Generally you should include the url for the dfl definitions.
> 
> Can you add it here to the commit log ?

Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?

Hao has some comments about this at

  https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com/

> 
> Otherwise fine.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>
> 
> > 
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>

This patch is now good to me.

Acked-by: Xu Yilun <yilun.xu@intel.com>

> > ---
> > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> >      the git message.
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >   drivers/uio/uio_dfl.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > index 89c0fc7b0cbc..8f39cc8bb034 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> >   }
> >   #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> >   static const struct dfl_device_id uio_dfl_ids[] = {
> >   	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> >   	{ }
> >   };
> >   MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
Tom Rix April 30, 2022, 2:54 p.m. UTC | #3
On 4/30/22 7:24 AM, Xu Yilun wrote:
> On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
>> On 4/28/22 5:57 PM, Tianfei Zhang wrote:
>>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>>
>>> Add the Device Feature List (DFL) feature id for the
>>> High Speed Serial Interface (HSSI) Subsystem to the
>>> table of ids supported by the uio_dfl driver.
>>>
>>> The HSSI Subsystem is a configurable set of IP blocks
>>> to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
>>> Like the Ethernet group used by the N3000 card, the HSSI
>>> Subsystem does not fully implement a network device from
>>> a Linux netdev perspective and is controlled and monitored
>>> from user space software via the uio interface.
>> Generally you should include the url for the dfl definitions.
>>
>> Can you add it here to the commit log ?
> Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?

Yes, exactly.

To someone not working the day-to-day working dfl they will have no clue 
where the fids come from.

When a new one is added to the kernel, it should have a listing in 
dfl-feature-id repo.

If it doesn't, there will be a future conflict.

Tom

>
> Hao has some comments about this at
>
>    https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com/
>
>> Otherwise fine.
>>
>> Reviewed-by: Tom Rix <trix@redhat.com>
>>
>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> This patch is now good to me.
>
> Acked-by: Xu Yilun <yilun.xu@intel.com>
>
>>> ---
>>> v3: change the name of this feature id to HSSI_SUBSYS and rewrite
>>>       the git message.
>>> v2: add HSSI introduction and the git repo of Feature ID table.
>>> ---
>>>    drivers/uio/uio_dfl.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
>>> index 89c0fc7b0cbc..8f39cc8bb034 100644
>>> --- a/drivers/uio/uio_dfl.c
>>> +++ b/drivers/uio/uio_dfl.c
>>> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>>>    }
>>>    #define FME_FEATURE_ID_ETH_GROUP	0x10
>>> +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
>>>    static const struct dfl_device_id uio_dfl_ids[] = {
>>>    	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
>>> +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
>>>    	{ }
>>>    };
>>>    MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
Xu Yilun April 30, 2022, 4:58 p.m. UTC | #4
On Sat, Apr 30, 2022 at 07:54:57AM -0700, Tom Rix wrote:
> 
> On 4/30/22 7:24 AM, Xu Yilun wrote:
> > On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
> > > On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > 
> > > > Add the Device Feature List (DFL) feature id for the
> > > > High Speed Serial Interface (HSSI) Subsystem to the
> > > > table of ids supported by the uio_dfl driver.
> > > > 
> > > > The HSSI Subsystem is a configurable set of IP blocks
> > > > to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> > > > Like the Ethernet group used by the N3000 card, the HSSI
> > > > Subsystem does not fully implement a network device from
> > > > a Linux netdev perspective and is controlled and monitored
> > > > from user space software via the uio interface.
> > > Generally you should include the url for the dfl definitions.
> > > 
> > > Can you add it here to the commit log ?
> > Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?
> 
> Yes, exactly.
> 
> To someone not working the day-to-day working dfl they will have no clue
> where the fids come from.
> 
> When a new one is added to the kernel, it should have a listing in
> dfl-feature-id repo.
> 
> If it doesn't, there will be a future conflict.

I remember a recent patch records the url in Documentation/fpga/dfl.rst.
Anyway I'm OK with or without the url in commit message.

Thanks,
Yilun

> 
> Tom
> 
> > 
> > Hao has some comments about this at
> > 
> >    https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com/
> > 
> > > Otherwise fine.
> > > 
> > > Reviewed-by: Tom Rix <trix@redhat.com>
> > > 
> > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > This patch is now good to me.
> > 
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > 
> > > > ---
> > > > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> > > >       the git message.
> > > > v2: add HSSI introduction and the git repo of Feature ID table.
> > > > ---
> > > >    drivers/uio/uio_dfl.c | 2 ++
> > > >    1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > index 89c0fc7b0cbc..8f39cc8bb034 100644
> > > > --- a/drivers/uio/uio_dfl.c
> > > > +++ b/drivers/uio/uio_dfl.c
> > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > > >    }
> > > >    #define FME_FEATURE_ID_ETH_GROUP	0x10
> > > > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> > > >    static const struct dfl_device_id uio_dfl_ids[] = {
> > > >    	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > > > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> > > >    	{ }
> > > >    };
> > > >    MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
Wu, Hao May 5, 2022, 6:22 a.m. UTC | #5
> On Sat, Apr 30, 2022 at 07:54:57AM -0700, Tom Rix wrote:
> >
> > On 4/30/22 7:24 AM, Xu Yilun wrote:
> > > On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
> > > > On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > >
> > > > > Add the Device Feature List (DFL) feature id for the
> > > > > High Speed Serial Interface (HSSI) Subsystem to the
> > > > > table of ids supported by the uio_dfl driver.
> > > > >
> > > > > The HSSI Subsystem is a configurable set of IP blocks
> > > > > to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> > > > > Like the Ethernet group used by the N3000 card, the HSSI
> > > > > Subsystem does not fully implement a network device from
> > > > > a Linux netdev perspective and is controlled and monitored
> > > > > from user space software via the uio interface.
> > > > Generally you should include the url for the dfl definitions.
> > > >
> > > > Can you add it here to the commit log ?
> > > Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?
> >
> > Yes, exactly.
> >
> > To someone not working the day-to-day working dfl they will have no clue
> > where the fids come from.
> >
> > When a new one is added to the kernel, it should have a listing in
> > dfl-feature-id repo.
> >
> > If it doesn't, there will be a future conflict.
> 
> I remember a recent patch records the url in Documentation/fpga/dfl.rst.
> Anyway I'm OK with or without the url in commit message.
> 

Yes, it's better that people can find that in Documentation instead of some
commit message. That's another patch from Tianfei.

Thanks
Hao

> Thanks,
> Yilun
> 
> >
> > Tom
> >
> > >
> > > Hao has some comments about this at
> > >
> > >
> https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@D
> M6PR11MB3819.namprd11.prod.outlook.com/
> > >
> > > > Otherwise fine.
> > > >
> > > > Reviewed-by: Tom Rix <trix@redhat.com>
> > > >
> > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > This patch is now good to me.
> > >
> > > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > >
> > > > > ---
> > > > > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> > > > >       the git message.
> > > > > v2: add HSSI introduction and the git repo of Feature ID table.
> > > > > ---
> > > > >    drivers/uio/uio_dfl.c | 2 ++
> > > > >    1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > > index 89c0fc7b0cbc..8f39cc8bb034 100644
> > > > > --- a/drivers/uio/uio_dfl.c
> > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > > > >    }
> > > > >    #define FME_FEATURE_ID_ETH_GROUP	0x10
> > > > > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> > > > >    static const struct dfl_device_id uio_dfl_ids[] = {
> > > > >    	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > > > > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> > > > >    	{ }
> > > > >    };
> > > > >    MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
diff mbox series

Patch

diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
index 89c0fc7b0cbc..8f39cc8bb034 100644
--- a/drivers/uio/uio_dfl.c
+++ b/drivers/uio/uio_dfl.c
@@ -45,9 +45,11 @@  static int uio_dfl_probe(struct dfl_device *ddev)
 }
 
 #define FME_FEATURE_ID_ETH_GROUP	0x10
+#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
 
 static const struct dfl_device_id uio_dfl_ids[] = {
 	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
+	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
 	{ }
 };
 MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);