| Message ID | 20230208080846.10795-1-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR | expand |
On 2/8/23 00:08, Ilpo Järvinen wrote: > rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of > normal -Exxxx codes. Convert <0 return from ->rsu_status() to > FW_UPLOAD_ERR_HW_ERROR. > > Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific") Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > --- > drivers/fpga/intel-m10-bmc-sec-update.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c > index f0acedc80182..d7e2f9f461bc 100644 > --- a/drivers/fpga/intel-m10-bmc-sec-update.c > +++ b/drivers/fpga/intel-m10-bmc-sec-update.c > @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec) > > ret = sec->ops->rsu_status(sec); > if (ret < 0) > - return ret; > + return FW_UPLOAD_ERR_HW_ERROR; > status = ret; > > if (!rsu_status_ok(status)) { >
On 2023-02-08 at 11:28:26 -0800, Russ Weight wrote: > > On 2/8/23 00:08, Ilpo Järvinen wrote: > > rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of > > normal -Exxxx codes. Convert <0 return from ->rsu_status() to > > FW_UPLOAD_ERR_HW_ERROR. > > > > Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific") > Reviewed-by: Russ Weight <russell.h.weight@intel.com> Acked-by: Xu Yilun <yilun.xu@intel.com> > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > > > --- > > drivers/fpga/intel-m10-bmc-sec-update.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c > > index f0acedc80182..d7e2f9f461bc 100644 > > --- a/drivers/fpga/intel-m10-bmc-sec-update.c > > +++ b/drivers/fpga/intel-m10-bmc-sec-update.c > > @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec) > > > > ret = sec->ops->rsu_status(sec); > > if (ret < 0) > > - return ret; > > + return FW_UPLOAD_ERR_HW_ERROR; > > status = ret; > > > > if (!rsu_status_ok(status)) { > > >
diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c index f0acedc80182..d7e2f9f461bc 100644 --- a/drivers/fpga/intel-m10-bmc-sec-update.c +++ b/drivers/fpga/intel-m10-bmc-sec-update.c @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec) ret = sec->ops->rsu_status(sec); if (ret < 0) - return ret; + return FW_UPLOAD_ERR_HW_ERROR; status = ret; if (!rsu_status_ok(status)) {
rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of normal -Exxxx codes. Convert <0 return from ->rsu_status() to FW_UPLOAD_ERR_HW_ERROR. Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific") Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/fpga/intel-m10-bmc-sec-update.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)