diff mbox series

dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema

Message ID 20240301161648.124859-1-animeshagarwal28@gmail.com (mailing list archive)
State New
Headers show
Series dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema | expand

Commit Message

Animesh Agarwal March 1, 2024, 4:16 p.m. UTC 
Convert the altera-fpga2sdram-bridge bindings to DT schema.

Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
---
 .../fpga/altera-fpga2sdram-bridge.txt         | 13 -----------
 .../fpga/altera-fpga2sdram-bridge.yaml        | 23 +++++++++++++++++++
 2 files changed, 23 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
 create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml

Comments

Conor Dooley March 1, 2024, 4:23 p.m. UTC | #1 
Hey,

On Fri, Mar 01, 2024 at 09:46:43PM +0530, Animesh Agarwal wrote:
> Convert the altera-fpga2sdram-bridge bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
>  .../fpga/altera-fpga2sdram-bridge.txt         | 13 -----------
>  .../fpga/altera-fpga2sdram-bridge.yaml        | 23 +++++++++++++++++++
>  2 files changed, 23 insertions(+), 13 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> deleted file mode 100644
> index 5dd0ff0f7b4e..000000000000
> --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Altera FPGA To SDRAM Bridge Driver
> -
> -Required properties:
> -- compatible		: Should contain "altr,socfpga-fpga2sdram-bridge"
> -
> -See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> -
> -Example:
> -	fpga_bridge3: fpga-bridge@ffc25080 {
> -		compatible = "altr,socfpga-fpga2sdram-bridge";
> -		reg = <0xffc25080 0x4>;
> -		bridge-enable = <0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> new file mode 100644
> index 000000000000..88bf9e3151b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera FPGA To SDRAM Bridge Driver
> +

You're missing maintainers: (shouldn't dt_binding_check complain?)

> +properties:
> +  compatible:
> +    enum:
> +      - altr,socfpga-fpga2sdram-bridge
> +
> +required:
> +  - compatible
> +

Missing "unevaluatedProperties: false".

> +examples:
> +  - |
> +    fpga_bridge3: fpga-bridge@ffc25080 {
> +        compatible = "altr,socfpga-fpga2sdram-bridge";
> +        reg = <0xffc25080 0x4>;
> +        bridge-enable = <0>;

This has not been documented in your binding. You need a ref to
fpga-bridge.yaml. Did you test this patch?

Cheers,
Conor.

> +    };
> -- 
> 2.44.0
>
Rob Herring (Arm) March 4, 2024, 5:07 p.m. UTC | #2 
On Fri, Mar 01, 2024 at 04:23:30PM +0000, Conor Dooley wrote:
> Hey,
> 
> On Fri, Mar 01, 2024 at 09:46:43PM +0530, Animesh Agarwal wrote:
> > Convert the altera-fpga2sdram-bridge bindings to DT schema.
> > 
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > ---
> >  .../fpga/altera-fpga2sdram-bridge.txt         | 13 -----------
> >  .../fpga/altera-fpga2sdram-bridge.yaml        | 23 +++++++++++++++++++
> >  2 files changed, 23 insertions(+), 13 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> >  create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > deleted file mode 100644
> > index 5dd0ff0f7b4e..000000000000
> > --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > +++ /dev/null
> > @@ -1,13 +0,0 @@
> > -Altera FPGA To SDRAM Bridge Driver
> > -
> > -Required properties:
> > -- compatible		: Should contain "altr,socfpga-fpga2sdram-bridge"
> > -
> > -See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> > -
> > -Example:
> > -	fpga_bridge3: fpga-bridge@ffc25080 {
> > -		compatible = "altr,socfpga-fpga2sdram-bridge";
> > -		reg = <0xffc25080 0x4>;
> > -		bridge-enable = <0>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > new file mode 100644
> > index 000000000000..88bf9e3151b6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > @@ -0,0 +1,23 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Altera FPGA To SDRAM Bridge Driver

Bindings are for h/w blocks, not Drivers.

> > +
> 
> You're missing maintainers: (shouldn't dt_binding_check complain?)

Yes. Patchwork says this failed to apply which is odd because it is 
doubtful that altera-fpga2sdram-bridge.txt has been modified.

Rob
Krzysztof Kozlowski March 6, 2024, 8:21 a.m. UTC | #3 
On 04/03/2024 18:07, Rob Herring wrote:
>>> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
>>> new file mode 100644
>>> index 000000000000..88bf9e3151b6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
>>> @@ -0,0 +1,23 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Altera FPGA To SDRAM Bridge Driver
> 
> Bindings are for h/w blocks, not Drivers.
> 
>>> +
>>
>> You're missing maintainers: (shouldn't dt_binding_check complain?)
> 
> Yes. Patchwork says this failed to apply which is odd because it is 
> doubtful that altera-fpga2sdram-bridge.txt has been modified.

The file was already converted by Michal, two months ago!

Animesh,
Please (almost) always work on current next. Also, before doing
conversion check if there is such work on the lists ("dfn:" on
lore.kernel.org).

It's waste of your and ours (three maintainers...) time, since this was
already done two months ago.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
deleted file mode 100644
index 5dd0ff0f7b4e..000000000000
--- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
+++ /dev/null
@@ -1,13 +0,0 @@ 
-Altera FPGA To SDRAM Bridge Driver
-
-Required properties:
-- compatible		: Should contain "altr,socfpga-fpga2sdram-bridge"
-
-See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
-
-Example:
-	fpga_bridge3: fpga-bridge@ffc25080 {
-		compatible = "altr,socfpga-fpga2sdram-bridge";
-		reg = <0xffc25080 0x4>;
-		bridge-enable = <0>;
-	};
diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
new file mode 100644
index 000000000000..88bf9e3151b6
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
@@ -0,0 +1,23 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Altera FPGA To SDRAM Bridge Driver
+
+properties:
+  compatible:
+    enum:
+      - altr,socfpga-fpga2sdram-bridge
+
+required:
+  - compatible
+
+examples:
+  - |
+    fpga_bridge3: fpga-bridge@ffc25080 {
+        compatible = "altr,socfpga-fpga2sdram-bridge";
+        reg = <0xffc25080 0x4>;
+        bridge-enable = <0>;
+    };