mbox series

[0/4] e2fsprogs: fix and document the stable_inodes feature

Message ID 20200401203239.163679-1-ebiggers@kernel.org
Headers show
Series e2fsprogs: fix and document the stable_inodes feature | expand

Message

Eric Biggers April 1, 2020, 8:32 p.m. UTC
Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
(which can exist if the stable_inodes feature is set) could be broken:

- Changing the filesystem's UUID
- Clearing the stable_inodes feature

Also document the stable_inodes feature in the appropriate places.

Eric Biggers (4):
  tune2fs: prevent changing UUID of fs with stable_inodes feature
  tune2fs: prevent stable_inodes feature from being cleared
  ext4.5: document the stable_inodes feature
  tune2fs.8: document the stable_inodes feature

 misc/ext4.5.in    | 16 ++++++++++++++++
 misc/tune2fs.8.in |  7 +++++++
 misc/tune2fs.c    | 10 ++++++++--
 3 files changed, 31 insertions(+), 2 deletions(-)

Comments

Theodore Y. Ts'o April 10, 2020, 3:24 p.m. UTC | #1
On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> (which can exist if the stable_inodes feature is set) could be broken:
> 
> - Changing the filesystem's UUID
> - Clearing the stable_inodes feature
> 
> Also document the stable_inodes feature in the appropriate places.
> 
> Eric Biggers (4):
>   tune2fs: prevent changing UUID of fs with stable_inodes feature
>   tune2fs: prevent stable_inodes feature from being cleared
>   ext4.5: document the stable_inodes feature
>   tune2fs.8: document the stable_inodes feature

Thanks, I've applied this patch series.

						- Ted
Eric Biggers May 7, 2020, 6:18 p.m. UTC | #2
On Fri, Apr 10, 2020 at 11:24:06AM -0400, Theodore Y. Ts'o wrote:
> On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> > Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> > (which can exist if the stable_inodes feature is set) could be broken:
> > 
> > - Changing the filesystem's UUID
> > - Clearing the stable_inodes feature
> > 
> > Also document the stable_inodes feature in the appropriate places.
> > 
> > Eric Biggers (4):
> >   tune2fs: prevent changing UUID of fs with stable_inodes feature
> >   tune2fs: prevent stable_inodes feature from being cleared
> >   ext4.5: document the stable_inodes feature
> >   tune2fs.8: document the stable_inodes feature
> 
> Thanks, I've applied this patch series.
> 

Ted, I still don't see this in git.  Are you planning to push it out?

- Eric
Eric Biggers June 15, 2020, 10:22 p.m. UTC | #3
On Thu, May 07, 2020 at 11:18:47AM -0700, Eric Biggers wrote:
> On Fri, Apr 10, 2020 at 11:24:06AM -0400, Theodore Y. Ts'o wrote:
> > On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> > > Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> > > (which can exist if the stable_inodes feature is set) could be broken:
> > > 
> > > - Changing the filesystem's UUID
> > > - Clearing the stable_inodes feature
> > > 
> > > Also document the stable_inodes feature in the appropriate places.
> > > 
> > > Eric Biggers (4):
> > >   tune2fs: prevent changing UUID of fs with stable_inodes feature
> > >   tune2fs: prevent stable_inodes feature from being cleared
> > >   ext4.5: document the stable_inodes feature
> > >   tune2fs.8: document the stable_inodes feature
> > 
> > Thanks, I've applied this patch series.
> > 
> 
> Ted, I still don't see this in git.  Are you planning to push it out?
> 

Ping?
Eric Biggers July 27, 2020, 4:45 p.m. UTC | #4
On Mon, Jun 15, 2020 at 03:22:40PM -0700, Eric Biggers wrote:
> On Thu, May 07, 2020 at 11:18:47AM -0700, Eric Biggers wrote:
> > On Fri, Apr 10, 2020 at 11:24:06AM -0400, Theodore Y. Ts'o wrote:
> > > On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> > > > Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> > > > (which can exist if the stable_inodes feature is set) could be broken:
> > > > 
> > > > - Changing the filesystem's UUID
> > > > - Clearing the stable_inodes feature
> > > > 
> > > > Also document the stable_inodes feature in the appropriate places.
> > > > 
> > > > Eric Biggers (4):
> > > >   tune2fs: prevent changing UUID of fs with stable_inodes feature
> > > >   tune2fs: prevent stable_inodes feature from being cleared
> > > >   ext4.5: document the stable_inodes feature
> > > >   tune2fs.8: document the stable_inodes feature
> > > 
> > > Thanks, I've applied this patch series.
> > > 
> > 
> > Ted, I still don't see this in git.  Are you planning to push it out?

Ping?
Eric Biggers Sept. 1, 2020, 4:19 p.m. UTC | #5
On Mon, Jul 27, 2020 at 09:45:55AM -0700, Eric Biggers wrote:
> On Mon, Jun 15, 2020 at 03:22:40PM -0700, Eric Biggers wrote:
> > On Thu, May 07, 2020 at 11:18:47AM -0700, Eric Biggers wrote:
> > > On Fri, Apr 10, 2020 at 11:24:06AM -0400, Theodore Y. Ts'o wrote:
> > > > On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> > > > > Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> > > > > (which can exist if the stable_inodes feature is set) could be broken:
> > > > > 
> > > > > - Changing the filesystem's UUID
> > > > > - Clearing the stable_inodes feature
> > > > > 
> > > > > Also document the stable_inodes feature in the appropriate places.
> > > > > 
> > > > > Eric Biggers (4):
> > > > >   tune2fs: prevent changing UUID of fs with stable_inodes feature
> > > > >   tune2fs: prevent stable_inodes feature from being cleared
> > > > >   ext4.5: document the stable_inodes feature
> > > > >   tune2fs.8: document the stable_inodes feature
> > > > 
> > > > Thanks, I've applied this patch series.
> > > > 
> > > 
> > > Ted, I still don't see this in git.  Are you planning to push it out?
> 
> Ping?

Ping.
Eric Biggers Sept. 21, 2020, 10:41 p.m. UTC | #6
On Tue, Sep 01, 2020 at 09:19:45AM -0700, Eric Biggers wrote:
> On Mon, Jul 27, 2020 at 09:45:55AM -0700, Eric Biggers wrote:
> > On Mon, Jun 15, 2020 at 03:22:40PM -0700, Eric Biggers wrote:
> > > On Thu, May 07, 2020 at 11:18:47AM -0700, Eric Biggers wrote:
> > > > On Fri, Apr 10, 2020 at 11:24:06AM -0400, Theodore Y. Ts'o wrote:
> > > > > On Wed, Apr 01, 2020 at 01:32:35PM -0700, Eric Biggers wrote:
> > > > > > Fix tune2fs to not allow cases where IV_INO_LBLK_64-encrypted files
> > > > > > (which can exist if the stable_inodes feature is set) could be broken:
> > > > > > 
> > > > > > - Changing the filesystem's UUID
> > > > > > - Clearing the stable_inodes feature
> > > > > > 
> > > > > > Also document the stable_inodes feature in the appropriate places.
> > > > > > 
> > > > > > Eric Biggers (4):
> > > > > >   tune2fs: prevent changing UUID of fs with stable_inodes feature
> > > > > >   tune2fs: prevent stable_inodes feature from being cleared
> > > > > >   ext4.5: document the stable_inodes feature
> > > > > >   tune2fs.8: document the stable_inodes feature
> > > > > 
> > > > > Thanks, I've applied this patch series.
> > > > > 
> > > > 
> > > > Ted, I still don't see this in git.  Are you planning to push it out?
> > 
> > Ping?
> 
> Ping.

Ping.