mbox series

[v2,0/2] fsverity-utils Makefile fixes

Message ID 20200520200811.257542-1-Jes.Sorensen@gmail.com (mailing list archive)
Headers show
Series fsverity-utils Makefile fixes | expand

Message

Jes Sorensen May 20, 2020, 8:08 p.m. UTC
From: Jes Sorensen <jsorensen@fb.com>

Hi

This addresses the comments to the previous version of these Makefile
changes.

Let me know if you have any additional issues with it?

I'd really love to see an official release soon that includes these
changes, which I can point to when submitting the RPM patches. Any
chance of doing 1.1 or something like that?

Cheers,
Jes


Jes Sorensen (2):
  Fix Makefile to delete objects from the library on make clean
  Let package manager override CFLAGS and CPPFLAGS

 Makefile | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Comments

Eric Biggers May 20, 2020, 9:03 p.m. UTC | #1
On Wed, May 20, 2020 at 04:08:09PM -0400, Jes Sorensen wrote:
> From: Jes Sorensen <jsorensen@fb.com>
> 
> Hi
> 
> This addresses the comments to the previous version of these Makefile
> changes.
> 
> Let me know if you have any additional issues with it?
> 
> I'd really love to see an official release soon that includes these
> changes, which I can point to when submitting the RPM patches. Any
> chance of doing 1.1 or something like that?
> 
> Cheers,
> Jes

I'll release v1.1 after I merge the libfsverity patches, but I need to look over
everything again first before committing to a stable API.  I'll try to get to it
this weekend; I'm also busy with a lot of other things.

Also, could you look over my patches and leave your Reviewed-by?  I expected
that you'd have a few more comments.

- Eric
Jes Sorensen May 20, 2020, 9:04 p.m. UTC | #2
On 5/20/20 5:03 PM, Eric Biggers wrote:
> On Wed, May 20, 2020 at 04:08:09PM -0400, Jes Sorensen wrote:
>> From: Jes Sorensen <jsorensen@fb.com>
>>
>> Hi
>>
>> This addresses the comments to the previous version of these Makefile
>> changes.
>>
>> Let me know if you have any additional issues with it?
>>
>> I'd really love to see an official release soon that includes these
>> changes, which I can point to when submitting the RPM patches. Any
>> chance of doing 1.1 or something like that?
>>
>> Cheers,
>> Jes
> 
> I'll release v1.1 after I merge the libfsverity patches, but I need to look over
> everything again first before committing to a stable API.  I'll try to get to it
> this weekend; I'm also busy with a lot of other things.
> 
> Also, could you look over my patches and leave your Reviewed-by?  I expected
> that you'd have a few more comments.

Sounds good, I'll go over them again and add the Reviewed-by lines once
I'm through.

Cheers,
Jes