diff mbox series

[xfstests-bld,v2] test-appliance: exclude generic/587 from the encrypt tests

Message ID 20200709185832.2568081-1-satyat@google.com
State Accepted
Headers show
Series [xfstests-bld,v2] test-appliance: exclude generic/587 from the encrypt tests | expand

Commit Message

Satya Tangirala July 9, 2020, 6:58 p.m. UTC
The encryption feature doesn't play well with quota, and generic/587
tests quota functionality.

Signed-off-by: Satya Tangirala <satyat@google.com>
---
 .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude        | 1 +
 .../test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude     | 1 +
 2 files changed, 2 insertions(+)

Comments

Eric Biggers July 9, 2020, 7:10 p.m. UTC | #1
On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> The encryption feature doesn't play well with quota, and generic/587
> tests quota functionality.
> 
> Signed-off-by: Satya Tangirala <satyat@google.com>

Reviewed-by: Eric Biggers <ebiggers@google.com>
Eric Biggers Sept. 1, 2020, 4:17 p.m. UTC | #2
On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > The encryption feature doesn't play well with quota, and generic/587
> > tests quota functionality.
> > 
> > Signed-off-by: Satya Tangirala <satyat@google.com>
> 
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Ted, are you planning to apply this?
Eric Biggers Sept. 21, 2020, 6:42 p.m. UTC | #3
On Tue, Sep 01, 2020 at 09:17:26AM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > > 
> > > Signed-off-by: Satya Tangirala <satyat@google.com>
> > 
> > Reviewed-by: Eric Biggers <ebiggers@google.com>
> 
> Ted, are you planning to apply this?

Ping.
Theodore Y. Ts'o Sept. 24, 2020, 5:27 p.m. UTC | #4
On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > The encryption feature doesn't play well with quota, and generic/587
> > tests quota functionality.
> > 
> > Signed-off-by: Satya Tangirala <satyat@google.com>
> 
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Applied, thanks

						- Ted
Eric Biggers Sept. 28, 2020, 10:06 p.m. UTC | #5
On Thu, Sep 24, 2020 at 01:27:29PM -0400, Theodore Y. Ts'o wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > > 
> > > Signed-off-by: Satya Tangirala <satyat@google.com>
> > 
> > Reviewed-by: Eric Biggers <ebiggers@google.com>
> 
> Applied, thanks
> 

Thanks.  Looks like you forgot to push?  Also, the kernel.org and github
repositories for xfstests-bld aren't in sync.

- Eric
diff mbox series

Patch

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index 47c26e7..07111c2 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -24,6 +24,7 @@  generic/270
 generic/381
 generic/382
 generic/566
+generic/587
 
 # encryption doesn't play well with casefold (at least not yet)
 generic/556
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
index cd60151..1f5a7e5 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
@@ -20,6 +20,7 @@  generic/235
 generic/270
 generic/382
 generic/204
+generic/587
 
 # These tests are also excluded in 1k.exclude.
 # See there for the reasons.