From patchwork Sun Aug 26 16:25:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10576291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7492915A7 for ; Sun, 26 Aug 2018 16:23:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72467298B4 for ; Sun, 26 Aug 2018 16:23:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6679E298B5; Sun, 26 Aug 2018 16:23:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 056A629571 for ; Sun, 26 Aug 2018 16:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbeHZUGc (ORCPT ); Sun, 26 Aug 2018 16:06:32 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:40560 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbeHZUGc (ORCPT ); Sun, 26 Aug 2018 16:06:32 -0400 Received: by mail-wm0-f67.google.com with SMTP id 207-v6so6048003wme.5; Sun, 26 Aug 2018 09:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=w52HNznNRT+44DzWnO6p1J7A/V+c8JlMaLPSlC/miCI=; b=coYYf71v5xriMr+xyooMsouGNNgB+IDN0qEBorRJ1A7ShDzxxqYLVlEnd7y1hbebzC 0Wft+iUPpA//Vadf3qOSRgUG2G6arrck5XLFGPBDZ27bWVqUSBzl2rTQ6YXR3vf7oiIk AOOSF8Pg+mVqPk6g/E7M9Uh9137hnGO5YwRlKzidP54X2xBPva2OBn2+Hr/WDNG1+geW TynWWBnv+/FJew/yySPzfycik4/W3jwlGSxmdJ6Nsk+u0CmQsHa70I9V77UQDJ4SoaYG N8AvBzTqweTiodQt6XUMKhSUefukGIoXlPrXpdChm/gT8U3whFWFqQ3wNz4flIEAmQuD Ok2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=w52HNznNRT+44DzWnO6p1J7A/V+c8JlMaLPSlC/miCI=; b=Lv3O6sqgMFATxdnVnFzzPvRmh6z2y/DVzLFNTILdjZj0NBhJNVwbYcTTGGnsDjeI5+ 5fQf53J/g1NyWcFpkRxibkXJNXWDxVGoeldvc4fFUEaiTU/vtY8oFn+CY6Q0nW+j3p2b NssCynOObZ7IdpLB5j9BxluQ9sKaMdWpiKhSmI/bk/zEgs1mTZcyYSD1lXh9fGWI316i kt84TcbcwWH7sKQgIUb+kxkpq5QVGofRrKuxrUi8LnpqkIEqezHHll/BMwZ34OymRGYw ohOyBFkls0IAd79uuW0FWhgCRHpQRrDwNR+6CWO2bBqj/H1Rv2bOK7cHSrhuyld8wpja dZIQ== X-Gm-Message-State: APzg51BKDXopV2weeShxQ4n2DUGK1tHwjEfyzW368ip72j9XfxKE7Veh hFo/ZZB+p3MOoapYZZJIBg/6bJGQ X-Google-Smtp-Source: ANB0VdbzafE2RqJFlspNcOQi7obF6/EVEiaoY6Tanxx3FnCLbDokOdXdka8QAsDCplTRJ+yachtKog== X-Received: by 2002:a1c:9dc3:: with SMTP id g186-v6mr3576647wme.26.1535300611033; Sun, 26 Aug 2018 09:23:31 -0700 (PDT) Received: from localhost.localdomain (bzq-166-168-31-246.red.bezeqint.net. [31.168.166.246]) by smtp.gmail.com with ESMTPSA id o33-v6sm27559238wrf.11.2018.08.26.09.23.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 26 Aug 2018 09:23:30 -0700 (PDT) From: Amir Goldstein To: Miklos Szeredi Cc: Al Viro , Dave Chinner , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2 0/6] Overlayfs stacked f_op fixes Date: Sun, 26 Aug 2018 19:25:11 +0300 Message-Id: <1535300717-26686-1-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Miklos, Following are fixes to some stacked f_op regressions, also availabel on my ovl-fixes branch [1]. Patches 2-3 fix fiemap() and swapon() regressions detected by xfstests. Per your suggestion, f_mapping now points to the overlay inode mapping and as a result, swapfile support is disabled on an overlayfs file. Also disabled is FIBMAP on an overlayfs file - not a big loss. Patch 1 adds the vfs helper file_real() to access overlayfs real file and patches 4-6 use this helper to untangle from the f_mapping change. Please note that patch 4 fixes a problem that was verified with an LTP test [2], but patches 5-6 fix theoretical problems that I have not yet demonstrated with a test. Thanks, Amir. [1] https://github.com/amir73il/linux/commits/ovl-fixes [2] https://github.com/amir73il/ltp/commits/overlayfs-devel Amir Goldstein (6): vfs: add helper to get "real" overlayfs file ovl: respect FIEMAP_FLAG_SYNC flag ovl: fix GPF in swapfile_activate of file from overlayfs over xfs vfs: fix readahead syscall on an overlayfs file vfs: fix fadvise64 syscall on an overlayfs file vfs: fix sync_file_range syscall on an overlayfs file fs/overlayfs/file.c | 4 +--- fs/overlayfs/inode.c | 10 ++++++++++ fs/sync.c | 14 ++++++++++---- include/linux/fs.h | 27 +++++++++++++++++++++++++++ mm/fadvise.c | 34 ++++++++++++++++++++-------------- mm/readahead.c | 9 +++++++-- 6 files changed, 75 insertions(+), 23 deletions(-)