From patchwork Mon Aug 27 12:55:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10577063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52FE4920 for ; Mon, 27 Aug 2018 12:54:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FFBA2943E for ; Mon, 27 Aug 2018 12:54:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33C6529958; Mon, 27 Aug 2018 12:54:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC9242943E for ; Mon, 27 Aug 2018 12:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbeH0Qkq (ORCPT ); Mon, 27 Aug 2018 12:40:46 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40524 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbeH0Qkq (ORCPT ); Mon, 27 Aug 2018 12:40:46 -0400 Received: by mail-wr1-f67.google.com with SMTP id n2-v6so13520426wrw.7; Mon, 27 Aug 2018 05:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QKfpPLaCkw0MyZo4NhKTUwbnPbI1SNkDtskKI4MMouo=; b=gI/KbgAThBmt9+iIqCJ9jFuQKavkbjxBQVMaxOc+qm4HfnmHEDC6D0E4F8Hpqq5pLM IgnK7rWO4CpmVsRUOEnofua2ly3vsAxX6hJj2IPDRaJ87og7r4rTS5SsNXL7c/PKi4FM NiY/YKPM+ZToq+2yM+ZkjfvYQfWU9zxgwt29uE6zLL0cnn9mI82x8dCoA1yhreRJv7wZ PJmtq8VeLYGSrBAJGU7hExAmwYKZ4035VE8Wpwfbsx49exKDdXqcudsT77tg4ZSqyEEI EOU9YOzDNKJ6rvQaEagR5Ubt82ruT3err7KwxCXVWyg6l98XJKr2VlpN3G+ZgRHNA4zf z42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QKfpPLaCkw0MyZo4NhKTUwbnPbI1SNkDtskKI4MMouo=; b=Fbpk8qPXmy507SyBRsZ9FOWeRrN0cpbr1etbkiK41f3wlxD5+GZMp3MU2DI1TIoCrg 1MFJHgpDklG6M9DFPd0qa/JLTwtpi3P3ZrrjkYLk8v/aFuelbFq8Dz6ypFG10wvPMsbv L4WcJyObGLwDV/Gw+WAfCA6e/KXvrZJ3E8SPK+ve9KBJsvO0wBteWxEe5+b8kRXg18rr 1Jsx/UbFxiqWXiA2UY5qfKyrMenBKbRYwWyhE504cZs5uUjDmPBMWn0iBmjAt8FzrE/V G9Y7VjS+7CU5tK6C4FXYsJ/E7Ic/eudG4hZf0TJ/nf8o9d9eV9XnxXv2nUAgRjX8OOV8 MInA== X-Gm-Message-State: APzg51AhJ6imcEZTuflIHs5SLJ47kjzaMTPFDyA44+nF6jcQk1soCsa1 HDrhsJyIVmfjk1V63qAT06r5eEdC X-Google-Smtp-Source: ANB0VdbJQoAZqER13Jgz8F22UCxBw1uIRkU7EV6qkbk8qu/xsRM2Klft3NAK1o3WHzmOsikTQPeLNg== X-Received: by 2002:adf:9031:: with SMTP id h46-v6mr1331087wrh.248.1535374453320; Mon, 27 Aug 2018 05:54:13 -0700 (PDT) Received: from localhost.localdomain ([141.226.8.68]) by smtp.gmail.com with ESMTPSA id z14-v6sm8504046wma.18.2018.08.27.05.54.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Aug 2018 05:54:12 -0700 (PDT) From: Amir Goldstein To: Miklos Szeredi Cc: Al Viro , Dave Chinner , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v3 0/6] Overlayfs stacked f_op fixes Date: Mon, 27 Aug 2018 15:55:58 +0300 Message-Id: <1535374564-8257-1-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Miklos, Following are fixes to some stacked f_op regressions, also available on my ovl-fixes branch [1]. Patches 1-2 fix fiemap() and swapon() regressions detected by xfstests (no change from v2). Patches 3-6 implement the fadvise() file operation in overlayfs to fix fadvise64(2) and readahead(2) syscalls, per your suggestion. Correctness and error cases of readahead(2) were verified with the LTP readahead tests including a new overlayfs readahead test [2]. Error cases of fadvise64(2) were verified with the LTP fadvise tests, but correctness is not yet covered by those tests. Thanks, Amir. Changes from v2: - avoid file_real() vfs hack - implement ovl_fadvise() - update vfs.txt [1] https://github.com/amir73il/linux/commits/ovl-fixes [2] https://github.com/amir73il/ltp/commits/overlayfs-devel Amir Goldstein (6): ovl: respect FIEMAP_FLAG_SYNC flag ovl: fix GPF in swapfile_activate of file from overlayfs over xfs Documentation/filesystems: update documentation of file_operations to kernel 4.18 vfs: add the fadvise() file operation vfs: implement readahead(2) using POSIX_FADV_WILLNEED ovl: add ovl_fadvise() Documentation/filesystems/vfs.txt | 25 +++++++++++-- fs/overlayfs/file.c | 21 +++++++++-- fs/overlayfs/inode.c | 10 +++++ include/linux/fs.h | 5 +++ mm/fadvise.c | 78 ++++++++++++++++++++++----------------- mm/readahead.c | 28 ++++++-------- 6 files changed, 110 insertions(+), 57 deletions(-)