From patchwork Thu Oct 4 01:02:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 10625435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F081615A6 for ; Thu, 4 Oct 2018 01:03:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD3F728592 for ; Thu, 4 Oct 2018 01:03:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0D5228D82; Thu, 4 Oct 2018 01:03:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 718DE28592 for ; Thu, 4 Oct 2018 01:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbeJDHyE (ORCPT ); Thu, 4 Oct 2018 03:54:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:55978 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726804AbeJDHyE (ORCPT ); Thu, 4 Oct 2018 03:54:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 82D39AFEA; Thu, 4 Oct 2018 01:03:14 +0000 (UTC) From: NeilBrown To: "J. Bruce Fields" , Anna Schumaker , Alexander Viro , Trond Myklebust Date: Thu, 04 Oct 2018 11:02:43 +1000 Subject: [PATCH 0/3] Fix regression in NFSv3 ACL setting Cc: Jan Harkes , linux-nfs@vger.kernel.org, Miklos Szeredi , Jeff Layton , linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, David Howells , coda@cs.cmu.edu, linux-fsdevel@vger.kernel.org, Christoph Hellwig Message-ID: <153861471803.30373.6184444014227748848.stgit@noble> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 013cdf1088d7 ("nfs: use generic posix ACL infrastructure for v3 Posix ACLs") introduce a regression for NFSv3 ACL setting. An owner should be able to set an ACL, but the new code tests for ownership in a way that is not reliable for NFSv3. For NFSv3 the only reliable test is to send the request to the server and see if it works. The first patch introduces MAY_ACT_AS_OWNER and relies on the filesystem to do the appropriate ownership test. This touches several filesystems, hence the long 'Cc' list. Following two patches are small code cleanups relating to this. Thanks, NeilBrown --- NeilBrown (3): VFS: introduce MAY_ACT_AS_OWNER VFS: allow MAY_ flags to be easily extended. NFSD - Use MAY_ACT_AS_OWNER fs/afs/security.c | 10 ++++++++++ fs/attr.c | 12 +++++------- fs/coda/dir.c | 10 ++++++++++ fs/fcntl.c | 2 +- fs/fuse/dir.c | 10 ++++++++++ fs/namei.c | 9 +++++++++ fs/nfs/dir.c | 8 ++++++++ fs/nfsd/vfs.c | 11 ++++++----- fs/nfsd/vfs.h | 33 ++++++++++++++++++--------------- fs/posix_acl.c | 2 +- fs/xattr.c | 2 +- include/linux/fs.h | 10 ++++++++++ 12 files changed, 89 insertions(+), 30 deletions(-) -- Signature